Fix str to snake to capture uppercase words followed by an underscore #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ariadne_codegen/utils.py, str_to_snake_case was not capturing uppercase words followed by an underscore. \W in the regex would capture all non word characters, but not an underscore. So, things like 'Router_Get' and 'RouterBGP_Get' would both be converted to 'router_get' instead of 'router_bgp_get' in the second case. This caused issues in module naming in the generated clients. This commit fixes the issue by explicitly adding an underscore to the regex.