Fix NULL pointer dereference in tgetstr function (CVE-2023-45918) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a NULL pointer dereference in the tgetstr function within lib_termcap.c. This issue was identified in CVE-2023-45918, which could cause the program to crash when invalid or unrecognized termcap capabilities were requested.
Problem:
The tgetstr function could return a NULL pointer when an invalid capability was passed, and this pointer was not checked before dereferencing it. This resulted in potential crashes due to memory access violations.
Solution:
Added a check for NULL before dereferencing the result of tgetstr.
If the result is NULL, the function now handles the error gracefully instead of attempting to dereference the invalid pointer.