-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No jquery #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xadada
force-pushed
the
no-jquery
branch
2 times, most recently
from
February 14, 2018 05:11
7e68a6f
to
c836951
Compare
0xadada
force-pushed
the
no-jquery
branch
4 times, most recently
from
February 18, 2018 23:06
07e3593
to
09f0693
Compare
On hold, fastboot is throwing an exception on |
* [x] Strip jQuery in ember-cli-build.js * [x] Try to ember-data to use ember-fetch instead of $.ajax * [x] app/adapters/application.js added the authorization: <bearer token> header to outgoing requests * [x] ma-create-media guards against disabled button * [x] updated dependencies
* [ ] get Mirage to work with ember-fetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove jQuery as a dependency
Resolves issue #31
status: On Hold
On hold, requires changes toWhy do we need to add theapp/adapters/application.js
that seem cludgyajaxOptions
hook if the DataProviderMixin already provides it?On hold, fastboot is throwing an exception oncatch
becauseember-fetch
isn't yet compatable with fastbootQuality
git rebase -i
offmaster
If there’s a checkbox you can’t complete for any reason, that's okay, just
explain in detail why you weren’t able to do so.