Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No jquery #59

Merged
merged 9 commits into from
May 6, 2019
Merged

No jquery #59

merged 9 commits into from
May 6, 2019

Conversation

0xadada
Copy link
Member

@0xadada 0xadada commented Feb 6, 2018

Remove jQuery as a dependency

Resolves issue #31

status: On Hold

  1. On hold, requires changes to app/adapters/application.js that seem cludgy Why do we need to add the ajaxOptions hook if the DataProviderMixin already provides it?
  2. On hold, fastboot is throwing an exception on catch because ember-fetch isn't yet compatable with fastboot

Quality

  • Submitted a ticket for my issue if one did not already exist
  • Ticket number is in the subject of the commit message
  • Used Github auto-closing keywords in the commit message or PR
  • Updated documentation for changes to the API
  • Added new tests for new functionality, and tests are passing
  • Code, writing, and design changes follow the Style guides
  • Single commit - git rebase -i off master
  • No dangling orphan code

If there’s a checkbox you can’t complete for any reason, that's okay, just
explain in detail why you weren’t able to do so.

@coveralls
Copy link

coveralls commented Feb 14, 2018

Coverage Status

Coverage increased (+0.2%) to 90.054% when pulling 526ae5b on no-jquery into f061ded on master.

@0xadada
Copy link
Member Author

0xadada commented Feb 24, 2018

On hold, fastboot is throwing an exception on catch because ember-fetch isn't yet ready

@0xadada
Copy link
Member Author

0xadada commented Mar 7, 2018

0xadada added 7 commits May 6, 2019 08:04
* [x] Strip jQuery in ember-cli-build.js
* [x] Try to ember-data to use ember-fetch instead of $.ajax
* [x] app/adapters/application.js added the authorization: <bearer token> header to outgoing requests
* [x] ma-create-media guards against disabled button
* [x] updated dependencies
* [ ] get Mirage to work with ember-fetch
@0xadada 0xadada removed the on-hold label May 6, 2019
@0xadada 0xadada merged commit 526ae5b into master May 6, 2019
@0xadada 0xadada deleted the no-jquery branch May 6, 2019 18:57
@0xadada 0xadada mentioned this pull request May 6, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants