Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify dockerfile #2

Open
wants to merge 3 commits into
base: ML9-shim15.8
Choose a base branch
from

Conversation

moriyama
Copy link

@moriyama moriyama commented Feb 7, 2025

I fixed the following two reviewer comments in the Dockerfile:

rhboot#421 (comment)
steve-mcintyre wrote on Sep 9, 2024:

  • I don't see why you're grabbing Peter's
    shim-unsigned-x64-15.8-2.el9.src.rpm rather than just using the
    upstream shim tarball directly. This isn't a blocker for this review
    as it's possible to check the tarball checksum from the
    src.rpm. Please don't do this again, though.

rhboot#421 (comment)
aronowski wrote on Dec 23, 2024:

Prefer using older minor system releases - the shim binary build does reproduce correctly now, but in case new tooling gets shipped as part of EL9.6, that can change unexpectedly.

@moriyama
Copy link
Author

I added check that the checksum of the downloaded shim tarball is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant