Feat/mip custom novel2 #1290
Merged
Feat/mip custom novel2 #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
部署成功，请访问地址获取编译代码。 Built with commit e1e6b83 |
easonyq
reviewed
Nov 21, 2018
src/mip-custom/data.js
Outdated
| for (var key in customConfig.paths) { | ||
| if (customConfig.paths.hasOwnProperty(key)) { | ||
| customConfig.paths[key] = customConfig.domain + customConfig.paths[key]; | ||
| var conf = JSON.parse(JSON.stringify(config)) |
easonyq
reviewed
Nov 21, 2018
src/mip-custom/mip-custom.js
Outdated
| @@ -413,16 +268,12 @@ define(function () { | |||
| // 性能日志 | |||
| var performance = {}; | |||
| performance.fetchStart = new Date() - 0; | |||
| var paramUrl = url; | |||
|
|
|||
| var paramUrl = url | |||
easonyq
reviewed
Nov 21, 2018
| @@ -478,7 +336,7 @@ define(function () { | |||
| * | |||
| * @param {Object} performance 性能参数 | |||
| */ | |||
| customElement.prototype.setPerformanceLogs = function (performance) { | |||
| customElement.prototype.setPerformanceLogs = function (performance, data) { | |||
There was a problem hiding this comment.
后面有个data.data.responseTime用到了；
easonyq
previously approved these changes
Nov 21, 2018
easonyq
approved these changes
Nov 21, 2018
apple01150525
approved these changes
Nov 21, 2018
jenkey2011
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
提交pr时需要关联issue，请大家遵守
#1289
1、升级点 （清晰准确的描述升级的功能点）
针对小说添加新的判断条件，并且把小说的内容从custom文件中抽离出来
2、影响范围 （描述该需求上线会影响什么功能）
使用了custom和小说的组件
3、自测 checklist
chrom
4、需要覆盖的场景和case
5、自测机型和浏览器
温馨提示：非 mip-extensions 仓库的组件请在组件平台提交，否则一律打回；