This repository has been archived by the owner on May 5, 2020. It is now read-only.
Add margin below legend via .heading-medium class #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To obtain a bigger margin between legend text and new radio/checkbox buttons, set class .heading-medium on legend element. This is similiar to the way the GOV.UK elements guide uses .heading-medium on the h1 elements in their examples. Without this change the legend text appears too close to the radio/checkbox buttons, due to zero margin between them.
|
@aliuk2012 Did you get a chance to review this suggested spacing improvement? What do you think? |
|
@robmckinnon I did, it is fairly straight forward, I'm busy thinking of how much impact this might have to those already using the gem and whether it should go into a major/minor version release. I am testing it on a few services I know use the existing gem to see if it might have some weird effect on them |
|
This PR is a great step towards what is recommended by gov.uk element but I think the class name should be an option and not hardcoded. gov.uk elements recommend a hidden class ( |
dankmitchell
suggested changes
Apr 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To obtain a bigger margin between legend text and new radio/checkbox buttons, set class .heading-medium on legend element.
This is similiar to the way the GOV.UK elements guide uses .heading-medium on the h1 elements in their examples.
Without this change the legend text appears too close to radio/checkbox buttons, due to zero margin between them.