Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Control Panel Role to Read AWS Managed Policies #5702

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

julialawrence
Copy link
Contributor

@julialawrence julialawrence commented Oct 16, 2024

Pull Request Objective

This piece of work is being tracked in
this Support Issue.

Allow Control Panel to get aws managed policies, specifically, the Textract managed policy.

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Terraform Component 🧱: aws-analytical-platform-production-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_static_analysis

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Terraform Component 🧱: aws-analytical-platform-development-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_plan

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Terraform Component 🧱: aws-analytical-platform-production-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_plan

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Terraform Component 🧱: aws-analytical-platform-development-cluster

Checkov 🛂: success

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_static_analysis

@julialawrence julialawrence marked this pull request as ready for review October 16, 2024 13:35
@julialawrence julialawrence requested a review from a team as a code owner October 16, 2024 13:35
Copy link
Member

@jacobwoffenden jacobwoffenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julialawrence julialawrence merged commit 929fc89 into main Oct 29, 2024
18 checks passed
@julialawrence julialawrence deleted the feature/allow-CP-role-to-read-managed-policies branch October 29, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants