Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve contacts, fix typedefs, v4 decode #85

Merged
merged 12 commits into from
Jul 22, 2024
Merged

Conversation

KraXen72
Copy link
Collaborator

@KraXen72 KraXen72 commented Jul 16, 2024

  • improve contacts handling (convert old format into new one)
  • fix type defs -> depends on V1.0.0 minibits cashu-ts#2 being merged or the changes implemented on the version of cashu-ts we will decide to use.
    • until this is merged, i changed the version in package.json to my fork. when that will be merged, i will revert that change.
  • implemented token v4 decoding
    • i have tested the decoding both by pasting a v3 and v4 token, and by scanning a v3 and v4 token (tokens taken from the spec, added cashu:// and pasted into an online qr-code generator). everything works, except token v4 warns about no currency info, so it defaults to sats.

REQUIRED:

minibits-cash
minibits-cash previously approved these changes Jul 17, 2024
@KraXen72
Copy link
Collaborator Author

for this pull request to be merged, whichever version of cashu-ts we end up using, will need to include the modifications to the type definitions i made in minibits-cash/cashu-ts#1.

@KraXen72 KraXen72 marked this pull request as draft July 18, 2024 10:24
@KraXen72 KraXen72 changed the title improve contacts, fix typedefs improve contacts, fix typedefs, v4 decode Jul 19, 2024
@minibits-cash minibits-cash marked this pull request as ready for review July 22, 2024 13:42
Copy link
Owner

@minibits-cash minibits-cash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tie node verzie v package.json su safe? Definuje ich totiz react native install script

@minibits-cash minibits-cash merged commit 8560a73 into main Jul 22, 2024
@KraXen72
Copy link
Collaborator Author

ah hej ja som tam dodal dalsie ltska lebo node 18 uz je out of date a ja pouzivam 22 (latest) - nemal som s tym ziadne problemy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants