enhance: Use mvcc timestamp as guarantee ts if set #38980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When MvccTimestamp is set, it could be used as guarantee timestamp directly instead of new ts allocated by scheduler reducing the waiting time when delegator has tsafe lag Signed-off-by: Congqi Xia <[email protected]>
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38980 +/- ##
=======================================
Coverage 81.12% 81.13%
=======================================
Files 1388 1388
Lines 196363 196364 +1
=======================================
+ Hits 159296 159312 +16
+ Misses 31470 31463 -7
+ Partials 5597 5589 -8
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jan 6, 2025
When MvccTimestamp is set, it could be used as guarantee timestamp directly instead of new ts allocated by scheduler reducing the waiting time when delegator has tsafe lag Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jan 6, 2025
When MvccTimestamp is set, it could be used as guarantee timestamp directly instead of new ts allocated by scheduler reducing the waiting time when delegator has tsafe lag Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 7, 2025
…9019) Cherry pick from master pr: #38980 When MvccTimestamp is set, it could be used as guarantee timestamp directly instead of new ts allocated by scheduler reducing the waiting time when delegator has tsafe lag Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MvccTimestamp is set, it could be used as guarantee timestamp directly instead of new ts allocated by scheduler reducing the waiting time when delegator has tsafe lag