Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[skip e2e] make more retries on codecov uploader #33683

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

yellow-shine
Copy link
Collaborator

@yellow-shine yellow-shine commented Jun 6, 2024

fix #32235

inspired by https://github.com/Kong/kubernetes-testing-framework/blob/main/.github/workflows/tests.yaml#L53-L69

What is changing:

Introducing the wretry.action to automatically retry the codecov-action in our CI/CD pipeline. This change is intended to enhance the robustness of our workflow by mitigating transient failures in the codecov-action.

Follow-up changes needed:

This retry mechanism will be removed once the issue codecov/codecov-action#926 is resolved or if GitHub Actions provides a built-in retry feature for actions.

@yellow-shine
Copy link
Collaborator Author

yellow-shine commented Jun 6, 2024

close: #32261
close 32261

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 6, 2024
Copy link
Contributor

mergify bot commented Jun 6, 2024

@samhuang-z

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@yellow-shine yellow-shine changed the title chore(ut): make more retries on codecov uploader fix: make more retries on codecov uploader Jun 6, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (cfea3f4) to head (1dfb22d).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33683      +/-   ##
==========================================
- Coverage   81.75%   81.75%   -0.01%     
==========================================
  Files        1019     1019              
  Lines      130732   130732              
==========================================
- Hits       106876   106874       -2     
+ Misses      19834    19829       -5     
- Partials     4022     4029       +7     

see 31 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, samhuang-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Contributor

/lgtm

@yellow-shine yellow-shine changed the title fix: make more retries on codecov uploader fix:[skip e2e] make more retries on codecov uploader Jun 7, 2024
@yellow-shine yellow-shine added the kind/enhancement Issues or changes related to enhancement label Jun 7, 2024
@mergify mergify bot added the ci-passed label Jun 7, 2024
@sre-ci-robot sre-ci-robot merged commit 19936d9 into milvus-io:master Jun 7, 2024
10 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jun 12, 2024
sre-ci-robot pushed a commit that referenced this pull request Jun 12, 2024
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
fix milvus-io#32235

inspired by
https://github.com/Kong/kubernetes-testing-framework/blob/main/.github/workflows/tests.yaml#L53-L69

### What is changing:
Introducing the
[wretry.action](https://github.com/Wandalen/wretry.action) to
automatically retry the
[codecov-action](https://github.com/codecov/codecov-action) in our CI/CD
pipeline. This change is intended to enhance the robustness of our
workflow by mitigating transient failures in the codecov-action.

### Follow-up changes needed:
This retry mechanism will be removed once the issue
[codecov/codecov-action#926](codecov/codecov-action#926)
is resolved or if GitHub Actions provides a built-in retry feature for
actions.

Signed-off-by: Liang Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error during codecov tokenless upload when contributing via pull request
3 participants