-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:[skip e2e] make more retries on codecov uploader #33683
Conversation
Signed-off-by: Liang Huang <[email protected]>
close: #32261 |
@samhuang-z Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33683 +/- ##
==========================================
- Coverage 81.75% 81.75% -0.01%
==========================================
Files 1019 1019
Lines 130732 130732
==========================================
- Hits 106876 106874 -2
+ Misses 19834 19829 -5
- Partials 4022 4029 +7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, samhuang-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
pr: #33683 Signed-off-by: Liang Huang <[email protected]>
pr: #33683 Signed-off-by: Liang Huang <[email protected]>
fix milvus-io#32235 inspired by https://github.com/Kong/kubernetes-testing-framework/blob/main/.github/workflows/tests.yaml#L53-L69 ### What is changing: Introducing the [wretry.action](https://github.com/Wandalen/wretry.action) to automatically retry the [codecov-action](https://github.com/codecov/codecov-action) in our CI/CD pipeline. This change is intended to enhance the robustness of our workflow by mitigating transient failures in the codecov-action. ### Follow-up changes needed: This retry mechanism will be removed once the issue [codecov/codecov-action#926](codecov/codecov-action#926) is resolved or if GitHub Actions provides a built-in retry feature for actions. Signed-off-by: Liang Huang <[email protected]>
fix #32235
inspired by https://github.com/Kong/kubernetes-testing-framework/blob/main/.github/workflows/tests.yaml#L53-L69
What is changing:
Introducing the wretry.action to automatically retry the codecov-action in our CI/CD pipeline. This change is intended to enhance the robustness of our workflow by mitigating transient failures in the codecov-action.
Follow-up changes needed:
This retry mechanism will be removed once the issue codecov/codecov-action#926 is resolved or if GitHub Actions provides a built-in retry feature for actions.