0.2.1 milo.util.deprecate; deprecated methods will log error

Gruntfile.js

@@ -112,7 +112,7 @@ module.exports = function(grunt) {
     grunt.registerTask('karmatest', 'karma');
     grunt.registerTask('htmltest', ['browserify:test1', 'watch']);
     grunt.registerTask('tests', ['mochaTest', 'browserify', 'karmatest']);
-    grunt.registerTask('default', ['test', 'browserify', 'exorcise', 'watch']);
+    grunt.registerTask('default', ['test', 'browserify', 'uglify', 'exorcise', 'watch']);
     grunt.registerTask('skiptest', ['browserify', 'watch']);
 
 };

bower.json

@@ -1,6 +1,6 @@
 {
   "name": "milo",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "homepage": "https://github.com/milojs/milo",
   "authors": [
     "MOL Technical <[email protected]>"

lib/components/ui/FoldTree.js

@@ -3,7 +3,7 @@
 var doT = require('milo-core').util.doT
     , componentsRegistry = require('../c_registry')
     , Component = require('../c_class')
-    , miloCount = require('../../util/count');
+    , uniqueId = require('../../util/unique_id');
 
 var TREE_TEMPLATE = '<ul class="ml-ui-foldtree-list">\
                         {{~ it.data.items :item:index }}\
@@ -87,7 +87,7 @@ function MLFoldTree$renderTree (data) {
     function _renderTree (data) {
         if (data.items)
             var itemsIDs = _.map(data.items, function(item) {
-                var id = miloCount();
+                var id = uniqueId();
                 self._itemsMap[id] = item;
                 return id; 
             });

lib/components/ui/RadioGroup.js

@@ -2,7 +2,7 @@
 
 var Component = require('../c_class')
     , componentsRegistry = require('../c_registry')
-    , miloCount = require('../../util/count')
+    , uniqueId = require('../../util/unique_id')
     , _ = require('milo-core').proto;
 
 
@@ -61,7 +61,7 @@ _.extendProto(MLRadioGroup, {
  */
 function MLRadioGroup$init() {
     _.defineProperty(this, '_radioList', [], _.CONF);
-    _.defineProperty(this, ELEMENT_NAME_PROPERTY, ELEMENT_NAME_PREFIX + miloCount());
+    _.defineProperty(this, ELEMENT_NAME_PROPERTY, ELEMENT_NAME_PREFIX + uniqueId());
     this._renderOptions = {};
     Component.prototype.init.apply(this, arguments);
 }

lib/config.js

@@ -67,5 +67,6 @@ config({
             timeout: 15000,
             responsePrefix: 'response_'
         }
-    }
+    },
+    deprecationWarning: 'once'
 });

lib/milo.js

@@ -63,7 +63,7 @@ _.extend(milo, {
     Component: require('./components/c_class'),
     Command: require('./command'),
     registry: require('./registry'),
-    milo_version: '0.2.0',
+    milo_version: '0.2.1',
     createComponentClass: require('./util/create_component_class'),
     destroy: destroy
 });

lib/util/component_name.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var count = require('./count')
+var uniqueId = require('./unique_id')
     , config = require('../config')
     , prefix = config.componentPrefix;
 
@@ -9,5 +9,5 @@ module.exports = componentName;
 
 
 function componentName() {
-    return prefix + count();
+    return prefix + uniqueId();
 }

lib/util/deprecate.js

@@ -0,0 +1,32 @@
+'use strict';
+
+
+var miloCore = require('milo-core')
+    , _ = miloCore.proto
+    , logger = miloCore.util.logger
+    , config = require('../config');
+
+
+module.exports = function deprecate(fn, message) {
+    var warned;
+    switch (typeof fn) {
+        case 'object':
+            return _.mapKeys(fn, function(f) { return deprecate(f, message); });
+        case 'function':
+            for (var prop in fn)
+                deprecated[prop] = deprecate(fn[prop], message);
+            return deprecated;
+        default:
+            return fn;
+    }
+
+
+    function deprecated() {
+        if (config.deprecationWarning
+            && (!warned || config.deprecationWarning == 'always')) {
+            logger.error(message || 'Function ' + fn.name + ' is DEPRECATED');
+            warned = true;
+        }
+        return fn.apply(this, arguments);
+    }
+};

lib/util/index.js

@@ -1,6 +1,7 @@
 'use strict';
 
-var miloCore = require('milo-core');
+var miloCore = require('milo-core')
+    , deprecate = require('./deprecate');
 
 /**
  * `milo.util`
@@ -10,20 +11,23 @@ var util = {
     request: require('./request'),
     websocket: require('./websocket'),
     check: miloCore.util.check,
-    error: require('./error'), // deprecated
-    count: require('./count'), // deprecated
-    uniqueId: require('./count'),
+    error: deprecate(require('./error'), 'milo.util.error is DEPRECATED and will be REMOVED soon!'),
+    count: deprecate(require('./unique_id'), 'milo.util.count is DEPRECATED! Use milo.util.uniqueId instead'),
+    uniqueId: require('./unique_id'),
     componentName: require('./component_name'),
     dom: require('./dom'),
     domListeners: require('./dom_listeners'),
     selection: require('./selection'),
     fragment: require('./fragment'),
-    jsonParse: require('./json_parse'), // deprecated
+    jsonParse: deprecate(require('./json_parse'), 'milo.util.jsonParse is DEPRECATED! Use _.jsonParse instead'),
     storage: require('./storage'),
     domReady: require('./domready'),
     dragDrop: require('./dragdrop'),
-    dialog: require('../components/ui/bootstrap/Dialog'), // deprecated - should be used from registry
-    alert: require('../components/ui/bootstrap/Alert'), // deprecated - should be used from registry
+    dialog: deprecate(require('../components/ui/bootstrap/Dialog'),
+        'milo.util.dialog is DEPRECATED! Use milo.registry.components.get(\'MLDialog\') instead'),
+    alert: deprecate(require('../components/ui/bootstrap/Alert'),
+        'milo.util.alert is DEPRECATED! Use milo.registry.components.get(\'MLAlert\') instead'),
+    deprecate: deprecate,
     doT: miloCore.util.doT,
     destroy: util_destroy
 };

lib/util/request.js

@@ -23,7 +23,7 @@
 
 var miloCore = require('milo-core')
     , _ = miloCore.proto
-    , count = require('./count')
+    , uniqueId = require('./unique_id')
     , config = require('../config')
     , logger = miloCore.util.logger
     , Messenger = miloCore.Messenger;
@@ -206,7 +206,7 @@ function request$jsonp(url, callback) {
     var script = document.createElement('script'),
         xPromise = _createXPromise(script),
         head = window.document.head,
-        uniqueCallback = config.request.jsonpCallbackPrefix + count();
+        uniqueCallback = config.request.jsonpCallbackPrefix + uniqueId();
 
     var opts = _.extend({ url: url }, jsonpOptions);
     if (_messenger) request.postMessageSync('request', { options: opts });

lib/util/storage/msg_src.js

@@ -5,7 +5,7 @@ var miloCore = require('milo-core')
     , MessageSource = miloCore.classes.MessageSource
     , _ = miloCore.proto
     , config = require('../../config')
-    , miloCount = require('../../util/count');
+    , uniqueId = require('../../util/unique_id');
 
 var StorageMessageSource = _.createSubclass(MessageSource, 'StorageMessageSource', true);
 
@@ -53,7 +53,7 @@ function StorageMessageSource$postMessage(message, data) {
 function StorageMessageSource$trigger(msgType, data) {
     var key = this.messageKey + msgType;
     data = data || {};
-    data[config.domStorage.messageTimestamp] = miloCount();
+    data[config.domStorage.messageTimestamp] = uniqueId();
     _.deferMethod(this.storage, 'setItem', key, data);
 }
 

lib/util/websocket/msg_src.js

@@ -5,7 +5,7 @@ var miloCore = require('milo-core')
     , MessageSource = miloCore.classes.MessageSource
     , _ = miloCore.proto
     , logger = miloCore.util.logger
-    , uniqueId = require('../../util/count')
+    , uniqueId = require('../../util/unique_id')
     , config = require('../../config')
     , check = miloCore.util.check
     , Match = check.Match;