feat: Makes public the onItemDrop function of MLListItem #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previous to this, I could not find anyway to hook into an item drop in a subclass of MLListItem
| } | ||
| }); | ||
|
|
||
|
|
||
| function MLListItem$init() { | ||
| MLListItem.super.init.apply(this, arguments); | ||
| this.on('childrenbound', onChildrenBound); | ||
|
|
| @@ -1051,7 +1051,9 @@ var MLListItem = module.exports = milo.createComponentClass({ | |||
| 'dragenter': { subscriber: onDragHover, context: 'owner' }, | |||
| 'dragover': { subscriber: onDragHover, context: 'owner' }, | |||
| 'dragleave': { subscriber: onDragOut, context: 'owner' }, | |||
| 'drop': { subscriber: onItemDrop, context: 'owner' } | |||
| 'drop': { context: 'owner', subscriber: function() { | |||
| this.onItemDrop.apply(this, arguments); | |||
jasoniangreen
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isDropAllowedwas already exposed. But my use-case is that I allow a drop to occur and then inform the user that they cannot drop the item if it doesn't meet some criteria (A failure dialog is only shown to the user once they commit to dropping the item and not before / on drag over)