Skip to content

Commit

Permalink
pick better names for new module-expansion properties
Browse files Browse the repository at this point in the history
In retrospect, 'module-body-outside-context wasn't a good
name for a property that turned out to hold only an
inside-edge scope.
  • Loading branch information
mflatt committed Jan 13, 2016
1 parent 6ea9e96 commit 052c7e4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions pkgs/racket-doc/scribblings/reference/stx-expand.scrbl
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ to the syntax object:
be exported indirectly through macro expansions. Definitions of
macro-generated identifiers create uninterned symbols in this list.}

@item{@indexed-racket['module-body-inside-context] --- a syntax
@item{@indexed-racket['module-body-context] --- a syntax
object whose @tech{lexical information} corresponds to the inside of
the module, so it includes the expansion's @tech{outside-edge scope}
and its @tech{inside-edge scope}; that is, the syntax object
Expand All @@ -157,7 +157,7 @@ to the syntax object:

@history[#:added "6.4.0.1"]}

@item{@indexed-racket['module-body-outside-context] --- a syntax
@item{@indexed-racket['module-body-inside-context] --- a syntax
object whose @tech{lexical information} corresponds to an identifier
that starts with no lexical context and is moved into the macro, so
that it includes only the expansions's @tech{inside-edge scope}.
Expand Down
4 changes: 2 additions & 2 deletions pkgs/racket-test-core/tests/racket/module.rktl
Original file line number Diff line number Diff line change
Expand Up @@ -1731,8 +1731,8 @@ case of module-leve bindings; it doesn't cover local bindings.

(test (not with-kar?) syntax-property m 'module-body-context-simple?)

(define i (syntax-property m 'module-body-inside-context))
(define o (syntax-property m 'module-body-outside-context))
(define i (syntax-property m 'module-body-context))
(define o (syntax-property m 'module-body-inside-context))

(test #t syntax? i)
(test #t syntax? o)
Expand Down
4 changes: 2 additions & 2 deletions racket/src/racket/src/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -7497,13 +7497,13 @@ static Scheme_Object *do_module(Scheme_Object *form, Scheme_Comp_Env *env,
stx = scheme_datum_to_syntax(scheme_intern_symbol("inside"), scheme_false, scheme_false, 0, 0);
stx = scheme_stx_add_module_context(stx, rn_set);
fm = scheme_stx_property(fm,
scheme_intern_symbol("module-body-inside-context"),
scheme_intern_symbol("module-body-context"),
scheme_stx_add_shift(stx, ps));

stx = scheme_datum_to_syntax(scheme_intern_symbol("outside"), scheme_false, scheme_false, 0, 0);
stx = scheme_stx_introduce_to_module_context(stx, rn_set);
fm = scheme_stx_property(fm,
scheme_intern_symbol("module-body-outside-context"),
scheme_intern_symbol("module-body-inside-context"),
scheme_stx_add_shift(stx, ps));
}

Expand Down

0 comments on commit 052c7e4

Please sign in to comment.