Skip to content

Commit

Permalink
Fix some names leftover from brax example
Browse files Browse the repository at this point in the history
Signed-off-by: Fabrice Normandin <[email protected]>
  • Loading branch information
lebrice committed Jul 18, 2024
1 parent ee2a414 commit 452037c
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
4 changes: 2 additions & 2 deletions benchmarks/purejaxrl/benchfile.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from milabench.pack import Package


class BraxBenchmark(Package):
class PureJaxRLBenchmark(Package):
base_requirements = "requirements.in"
main_script = "main.py"


__pack__ = BraxBenchmark
__pack__ = PureJaxRLBenchmark()
8 changes: 7 additions & 1 deletion benchmarks/purejaxrl/main.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
"""PureJaxRL"""
"""PureJaxRL example based on https://github.com/luchris429/purejaxrl/blob/main/examples/walkthrough.ipynb
TODOs:
- This is a simple example on CartPole, it would be preferable to do something more serious (and for longer).
- Should probably try something like https://github.com/luchris429/purejaxrl/blob/main/purejaxrl/experimental/s5/ppo_s5.py
"""
import dataclasses
import os

Expand Down
5 changes: 3 additions & 2 deletions benchmarks/purejaxrl/voirfile.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
from dataclasses import dataclass

from voir import configurable
from voir.instruments import dash, early_stop, log, rate
from voir.phase import StopProgram
from voir.instruments import dash, early_stop, gpu_monitor, log, rate

from benchmate.monitor import monitor_monogpu


Expand Down Expand Up @@ -46,4 +47,4 @@ def instrument_main(ov, options: Config):
try:
yield ov.phases.run_script
except StopProgram:
print("early stopped")
print("early stopped")

0 comments on commit 452037c

Please sign in to comment.