Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
mikeromard committed Nov 9, 2023
1 parent 5d1b556 commit c8d390d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,5 @@ This is a proof-of-concept for updating an RSS feed from a markdown file that se
* If `markdown_to_rss.py` finds more than one new entry in `test_product_updates.md`, it makes no effort to sort them. The sample entries in `test_product_updates.md` are from most recent to oldest, and they are processed in that order.
* For example, if both the first and second entries in `test_product_updates.md` are new, the first entry gets added as the first `<item>` in `test_rss_feed.xml`, and then the second entry gets added as the first `<item>`, meaning that the first entry is now the second `<item>`. This could be handled better by reversing the order of the list of entries before processing them.
* Both entries would also have identical timestamps in their `<pubDate>` elements. It may be a good idea to update the timestamp when processing each entry, and introduce a 1 second delay to ensure that each timestamp is unique. If this is implemented, the last timestamp should also be used to update the `<pubDate>` for the feed itself, since it should presumably not be older than any of the `<pubDate>` timestamps in the `<item>` elements.
* Where a new `<item>` is inserted is hard-coded. It would be good if the script could determine the index of the first `<item>` and insert each new `<item>` at that index, rather than relying on the number of elements before the first `<item>` staying the same.
* Where a new `<item>` is inserted is hard-coded. It would be good if the script could determine the index of the first `<item>` and insert each new `<item>` at that index, rather than relying on the number of elements before the first `<item>` staying the same.
* The script relies on entries in the markdown file being formatted in a specific way, where each entry starts with and h2 (##) and the first line of text after that is the category of the entry (such as New Feature, Alpha, Beta, and so on). So if there's no category specified, the first paragraph of the entry gets treated as a category anyway and doesn't render in the `<description>` element of the `<item>` and doesn't appear in the body of the post when you view it in an RSS reader.

0 comments on commit c8d390d

Please sign in to comment.