This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 116
Strip out white space text nodes #31
Open
RacingTadpole
wants to merge
1
commit into
mikenikles:master
Choose a base branch
from
TerriaJS:tablespan
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -101,6 +101,47 @@ describe('Html2React', function() { | |
|
||
assert.equal(reactHtml, htmlExpected); | ||
}); | ||
|
||
it('should not insert spans into tables even if there is white space', function() { | ||
var htmlInput = '<table> <tbody> <tr>\n<td>x</td> <td>3</td> </tr> </tbody> </table>'; | ||
var htmlExpected = '<table><tbody><tr><td>x</td><td>3</td></tr></tbody></table>'; | ||
|
||
var reactComponent = parser.parse(htmlInput); | ||
var reactHtml = ReactDOMServer.renderToStaticMarkup(reactComponent); | ||
|
||
assert.equal(reactHtml, htmlExpected); | ||
}); | ||
|
||
it('should preserve leading white space in a div', function() { | ||
var htmlInput = '<div> hi</div>'; | ||
|
||
var reactComponent = parser.parse(htmlInput); | ||
var reactHtml = ReactDOMServer.renderToStaticMarkup(reactComponent); | ||
|
||
assert.equal(reactHtml, htmlInput); | ||
}); | ||
|
||
// Should it strip out contents of a div containing only white space? | ||
it('should strip out contents of a div containing only white space', function() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we actually remove text nodes that are whitespace only? The comment seems to indicate the PR author isn't sure either. |
||
var htmlInput = '<div> </div>'; | ||
var htmlExpected = '<div></div>'; | ||
|
||
var reactComponent = parser.parse(htmlInput); | ||
var reactHtml = ReactDOMServer.renderToStaticMarkup(reactComponent); | ||
|
||
assert.equal(reactHtml, htmlExpected); | ||
}); | ||
|
||
// Should it strip out white space that is a sibling to an element? | ||
it('should strip out white space that is a sibling to an element', function() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this make any semantic difference compared to just stripping whitespace text nodes? |
||
var htmlInput = '<div> <span>hi</span>bye</div>'; | ||
var htmlExpected = '<div><span>hi</span>bye</div>'; | ||
|
||
var reactComponent = parser.parse(htmlInput); | ||
var reactHtml = ReactDOMServer.renderToStaticMarkup(reactComponent); | ||
|
||
assert.equal(reactHtml, htmlExpected); | ||
}); | ||
}); | ||
|
||
describe('parse invalid HTML', function() { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this test doesn't add anything except verify that whitespace text nodes are stripped.