Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small Gtk.STOCK_COPY button near 'Password:' fields #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asashnov
Copy link

Increase usability: add a small button to copy a password.

Now:

  • right click on 'Password:' field value (******)
  • move mouse a bit down (but not too far);
  • left-click 'Copy password'

With this change:

  • left-click on 'copy' button on the right from 'Password:' (after ***** )

Screenshot from 2021-01-31 04-29-18

Testing strategy

For any entry for your database, try using this new button instead of right-clicking on password, 'Copy password' from the menu. The new button should work the same, but much handy.

Type of change

  • ✅ New feature (change that adds functionality)

@asashnov
Copy link
Author

Actually, I just realized (after about 10 years of using this app) that it has 'Activate' action on double-click- copy password and open URL of a website.

But I always used clicking on URL field, and manually copying the password.

So, maybe instead (or with) adding this button we should show for the first time URL value is clicked: Did you know you may double-click the enlty in list, so this URL will be opened, and the password copied to clipboard?

Or, alternatively, it may be a tooltip in list for an item under mouse pointer: You can double-click the item to activate. Password will be copied to clipboard and the URL is opened.
(this tooltip should be shown if the entry is a website, and double-click action is 'Activate').

@asashnov
Copy link
Author

But my further user experience with the program shows that this 'Copy Password' button is still useful. We can add 'See password' button also to show password 'in place' instead of ******
It can be useful when needed to enter the password into my phone.

@mikelolasagasti
Copy link
Owner

Thanks for the PR @asashnov !

We can add 'See password' button also to show password 'in place' instead of ******

That would be ctrl+p, that is what I use, but it can be interesting to have that button next to the password.

Would you be interested in extending PR to add that button?

@mikelolasagasti mikelolasagasti self-requested a review March 4, 2021 16:52
@mikelolasagasti mikelolasagasti self-assigned this Mar 4, 2021
@mikelolasagasti mikelolasagasti added this to the 0.5.5 milestone Mar 4, 2021
@mikelolasagasti mikelolasagasti modified the milestones: 0.5.5, 0.5.6 Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants