Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The line chart for the odometer is ready. #374

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

lukasskolek
Copy link

@lukasskolek lukasskolek commented Dec 3, 2024

What it Does

Closes #353
It added line chart to the odometerview. I added a few more instances of odometer readings into the preview, so that it shows better in the previewer.

How I Tested

After entering a new odometer reading the chart is displayed above the list. I was not able to test it all the way that I wanted because the firebase emulator wasn't working properly for me. Even though I tried restarting everything and I ran the emulator from within the backend and it started up properly in the terminal, however, when I tried running simulator it got this error.

11.4.0 - [FirebaseFirestore][I-FST000001] WatchStream (80b17503) Stream error: 'Unknown: An internal error has occurred, print and inspect the error details for more information.'

Notes

  • Anything else that should be noted about how you implemented this feature?

Interactive chart would be a good next step perhaps. It was in WWDC23 video here. https://developer.apple.com/videos/play/wwdc2023/10037/

Screenshot

  • Add a screenshot of your new feature! OR show a screen recording of it in action. (On the simulator press Cmd + R to record, and the stop button when done). This video should be no longer than 30 seconds.
    Simulator Screenshot - iPhone 16 - 2024-12-02 at 23 32 38

@mikaelacaron
Copy link
Owner

I'll review this soon! sorry for the delay, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE - Add a Line Chart to OdometerView
2 participants