Add VehicleDetailView
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added VehicleDetailView to show vehicle details. Also, any edits could be made through the EditVehicleView connection. Updated SettingsView so that each vehicle is tappable to show VehicleDetailView Updated EditVehicleView so that when a change occur, it optionally notifies the parent view.
mikaelacaron
changed the title
VehicleDetailView for issue #357
mikaelacaron
changed the title
VehicleDetailView for issue #357VehicleDetailView
mikaelacaron
approved these changes
Oct 28, 2024
Comment on lines
128
to
133
| .frame(maxWidth: .infinity, alignment: .leading) | ||
| .contentShape(Rectangle()) | ||
| .onTapGesture { | ||
| selectedVehicle = vehicle | ||
| isShowingVehicleDetailView = true | ||
| } |
There was a problem hiding this comment.
we changed this to be inside a Button as opposed to a onTapGesture because using a Button it's more accessible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it Does
VehicleDetailViewto theSettingsView#357VehicleDetailViewto show vehicle details. Also, any edits could be made through theEditVehicleViewconnection.SettingsViewso that each vehicle is tappable to showVehicleDetailView.EditVehicleViewso that when a change occur, it optionally notifies the parent view.How I Tested
SettingsViewVehicleNotes
Screenshot