Improvement - updated the DashboardView row appearance #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelacaron
approved these changes
Oct 27, 2024
| @@ -30,20 +30,24 @@ struct DashboardView: View { | |||
| NavigationStack { | |||
| List { | |||
| ForEach(viewModel.searchedEvents) { event in | |||
| VStack(alignment: .leading, spacing: 8) { | |||
| VStack(alignment: .leading) { | |||
There was a problem hiding this comment.
Suggested change
| VStack(alignment: .leading) { | |
| VStack(alignment: .leading, spacing: 4) { |
changing the spacing to 4, just cause personal preference when I was looking at it in the simulator
|
|
||
| let vehicleName = viewModel.vehicles.first { $0.id == event.vehicleID }?.name | ||
| if let vehicleName { | ||
| Text("\(vehicleName) on \(event.date, formatter: self.eventDateFormat)", | ||
| comment: "Maintenance list item for a vehicle on a date") | ||
| Text("For: \(vehicleName)") |
There was a problem hiding this comment.
adding a comment here for accessibility when people are translating this it gives more context about that text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it Does
DashboardView#333How I Tested
For example:
Notes
Screenshot