update the german localization #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the second attempt to clear that issue, the first pr #236 was messed up due to merge conflicts with dev. |
mikaelacaron
approved these changes
Oct 30, 2023
Comment on lines
64
to
69
| "de" : { | ||
| "stringUnit" : { | ||
| "state" : "translated", | ||
| "value" : "" | ||
| } | ||
| }, |
There was a problem hiding this comment.
I think this shouldn't be empty, but should be %lld %@ because this is filled in automatically, from computed properties and such, if it was empty, I think it would end up showing as an empty string, when there should be a value there
|
That makes a whole lot of sense, I was assuming that it would take the default English value in this case, so TIL.
Thanks for the additional commit and letting me know.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it Does