Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow right clicking multiple files #410

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MamiyaOtaru
Copy link

probably a better way to do this. Basically checks if the right clicked item is one of the already selected items and if so doesn't change the selection. When an action is carried out, the full list is then returned to be acted on

@MamiyaOtaru
Copy link
Author

intended to address Right Mouse Click Context Menu issues #260

logic to (optionally) not deselect current selection in directory pane on right click moved to wfdlgs.  Avoids the creation of a new message type to be sent to wdir
@malxau-msft
Copy link
Contributor

Thanks @MamiyaOtaru ! Unfortunately the CLA is still showing as not being signed, and we can't move forward with this until it is.

Is there a reason for not using LB_GETSEL? As far as I can tell, this would eliminate the need for the allocation and loop.

@MamiyaOtaru
Copy link
Author

MamiyaOtaru commented Nov 1, 2024

@microsoft-github-policy-service agree

Sorry, didn't see the CLA thing

"Is there a reason for not using LB_GETSEL?" - lack of familiarity with the code. If that would work I'd be fine with someone doing it that way, using my submission as a base or not. Or I can try to figure that out, if I remind myself how it all works (been a while, sorry again)

@malxau-msft
Copy link
Contributor

Thanks for taking care of the CLA. What I was trying to say about LB_GETSEL is in commit e14a3ca - I think this is doing the same thing? Is there something I missed?

Also while looking at this again today, the code immediately below this is checking if the first selected item is a directory, and if so, disable the edit item. Unfortunately both open and edit don't work for multiple files - see the code in OpenOrEditSelection which calls FS_GETSELECTION. 6ceaee6 disables open/edit if multiple objects are selected, which seems like the easiest path. A better change would be to change OpenOrEditSelection to handle this, but it seems distinct from the multiple selection change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants