Add support for calling conventions #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As expected, the build failed the gnu test of |
|
I haven't looked at the symbol names in detail, but this also fixes #1964 (comment) |
|
Haven't finished looking, but so far, I found that |
|
Yup can confirm that. |
|
There are a lot more now cdecl that aren't in the real DLLs (probably incomplete list): |
|
Oh, I just noticed there are some |
|
Created microsoft/win32metadata#1217 - hopefully @sotteson1 can take a quick look but at a glance I do agree that this metadata is no good as is. |
These all looks like win32metadata bugs where the signatures are improperly declared, mixing 32 bit and 64 bit integer types. For example, the win32metadata uses enums like I wish the win32metadata could just validate this against the lib files in the SDK using dumpbin. I'll create a win32metadata issue for this. |
|
So we have the following two new win32metadata issues blocking the adoption of calling convention support and publishing accurate import libs: microsoft/win32metadata#1217 I think I'll just disable the calling convention support for now (so that everything appears to use |
|
|
|
@glandium Good catch, we'll generate fresh ones tomorrow. We might be regenerating again anyway w/ some big incoming metadata changes. |
|
Yes, I'm just waiting for another win32 metadata update since what we have right now is broken anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #1996 that introduced win32 metadata capturing calling conventions, this update adds support for translating that metadata into Rust bindings. It also corrects a few issues with calculating the
stdcallstack size requirements. It now correctly takes into account padding and alignment.Fixes #1985