Do a better job of detecting when enums mess with sizes #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebattista
previously approved these changes
Sep 6, 2022
elachlan
reviewed
Sep 7, 2022
| { | ||
| "name": "ISC_REQ_FLAGS", | ||
| "flags": true, | ||
| "autoPopulate": { | ||
| "filter": "ISC_REQ_", | ||
| "filter": "ISC_REQ_(?!MESSAGES|DEFERRED_CRED_VALIDATION)", |
There was a problem hiding this comment.
Cool! I didn't know you could do that!
There was a problem hiding this comment.
I wasn't sure how to do it until I needed it. :)
mikebattista
previously approved these changes
Sep 7, 2022
| case "ULONG64": | ||
| case "INT64": | ||
| case "UINT64": | ||
| case "__int64": |
There was a problem hiding this comment.
“__int64” cannot ever match, because of ToUpperInvariant. Filed as #1418.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a better job of detecting when enums change the sizes of parameters or fields
Fix up some issues the new logic detected
Fixes #1221