Skip to content

Commit

Permalink
test: remove SPN skip from eventhouses and semantic models tests (#106)
Browse files Browse the repository at this point in the history
# 📥 Pull Request

## ❓ What are you trying to address

This pull request includes changes to remove conditional test skips in
the `internal/services/eventhouse/data_eventhouses_test.go` and
`internal/services/semanticmodel/data_semantic_models_test.go` files.
The most important changes include removing the
`testhelp.ShouldSkipTest` checks from the affected test functions.

## ✨ Description of new changes

*
[`internal/services/eventhouse/data_eventhouses_test.go`](diffhunk://#diff-d9e4745346ceb6b5e1e0db0b1d6ca4bf65525ef2b056c76203700fd592e81c4cL78-L81):
Removed the conditional skip check for SPN support in the
`TestAcc_EventhousesDataSource` test function.
*
[`internal/services/semanticmodel/data_semantic_models_test.go`](diffhunk://#diff-018ed8f2e732aaa3c238a1294df9d5d1c946cb03752d7af1b23d5af37da9c1adL78-L81):
Removed the conditional skip check for SPN support in the
`TestAcc_SemanticModelsDataSource` test function.
  • Loading branch information
DariuszPorowski authored Nov 22, 2024
1 parent e14f7d4 commit e262c93
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions internal/services/eventhouse/data_eventhouses_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ func TestUnit_EventhousesDataSource(t *testing.T) {
}

func TestAcc_EventhousesDataSource(t *testing.T) {
if testhelp.ShouldSkipTest(t) {
t.Skip("No SPN support")
}

workspaceID := *testhelp.WellKnown().Workspace.ID

resource.ParallelTest(t, testhelp.NewTestAccCase(t, nil, nil, []resource.TestStep{
Expand Down
4 changes: 0 additions & 4 deletions internal/services/semanticmodel/data_semantic_models_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ func TestUnit_SemanticModelsDataSource(t *testing.T) {
}

func TestAcc_SemanticModelsDataSource(t *testing.T) {
if testhelp.ShouldSkipTest(t) {
t.Skip("No SPN support")
}

workspaceID := *testhelp.WellKnown().Workspace.ID

resource.ParallelTest(t, testhelp.NewTestAccCase(t, nil, nil, []resource.TestStep{
Expand Down

0 comments on commit e262c93

Please sign in to comment.