Improvements to Decommit Strategies #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance on Windows was significantly regressed by the notify_using during the bump allocation. This change removes that. It appears that the pages are already committed by the large allocator.
The DecommitAll strategy performs badly. We are not functionally testing it, and it does not seem investing in it due to its performance.
The code for decommit was distribured in the code base. Removing Decommit All means that it can logically reside in lthe arge allocator.
mjp41
force-pushed
the
decommit_perf
branch
2 times, most recently
from
079a105 to
4003805
Compare
|
@davidchisnall, this PR mostly does some tidying, but makes addressing some issues associated #114 much easier. But is does massively improve Windows perf. |
davidchisnall
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily fixes a performance issue on Windows where Commit (NotifyUsing) was called too often.
The other commits tidy the decommit code to remove an unused poorly performing strategy, and refactor the code.