.Net: adds support for strict mode with OpenAI #9924

baywet · 2024-12-10T12:40:39Z

fixes #9786
closes #9741

Signed-off-by: Vincent Biret <[email protected]>

…pping Signed-off-by: Vincent Biret <[email protected]>

Signed-off-by: Vincent Biret <[email protected]>

… generation Signed-off-by: Vincent Biret <[email protected]>

Signed-off-by: Vincent Biret <[email protected]>

…-kernel into feat/strict-mode

Signed-off-by: Vincent Biret <[email protected]>

dotnet/samples/Concepts/Plugins/ApiManifestBasedPlugins.cs

SergeyMenshykh · 2025-01-02T14:41:21Z

dotnet/src/Agents/OpenAI/Internal/AssistantThreadActions.cs

@@ -178,7 +178,7 @@ public static async IAsyncEnumerable<ChatMessageContent> GetMessagesAsync(Assist

        FunctionCallsProcessor functionProcessor = new(logger);
        // This matches current behavior.  Will be configurable upon integrating with `FunctionChoice` (#6795/#5200)
-        FunctionChoiceBehaviorOptions functionOptions = new() { AllowConcurrentInvocation = true, AllowParallelCalls = true };
+        FunctionChoiceBehaviorOptions functionOptions = new() { AllowConcurrentInvocation = true, AllowParallelCalls = true, AllowStrictSchemaAdherence = true };


Shouldn't we have the strict mode configurable? To keep it off by default and allow it to be enabled if necessary. This way, we can avoid unnecessary behavioral changes.

SergeyMenshykh · 2025-01-02T15:15:57Z

dotnet/src/Functions/Functions.OpenApi/Model/RestApiParameter.cs

@@ -33,7 +33,7 @@ public string? ArgumentName
    /// <summary>
    /// The parameter type - string, integer, number, boolean, array and object.
    /// </summary>
-    internal string Type { get; }
+    public string Type { get; }


The type and array item type parameters together with constructor were intentionally kept internal because their types will change during the migration to Microsoft.OpenApi V2. Consider adding a freezable setter to the Schema property, like the one for the ArgumentName property, so that a modified schema can be assigned.

The reason why I had to change those to public is because I need access to it in the samples.
https://github.com/baywet/semantic-kernel/blob/3b296e91b4e35a63edf537d58e56a7ef4dcd2c6d/dotnet/samples/Concepts/Plugins/CopilotAgentBasedPlugins.cs#L161

Do you have an example of a freezable setter implementation?

dotnet/src/Functions/Functions.OpenApi/Extensions/RestApiOperationExtensions.cs

Co-authored-by: SergeyMenshykh <[email protected]>

Signed-off-by: Vincent Biret <[email protected]>

eiriktsarpalis and others added 23 commits December 10, 2024 07:39

Replace stj-schema-mapper source code with M.E.AI schema generation

d3d5edc

feat: adds strict mode flag to function calling

535bd6e

Signed-off-by: Vincent Biret <[email protected]>

feat: adds strict schema function behaviour and maps it to the metadata

ecc2cf8

Signed-off-by: Vincent Biret <[email protected]>

chore: adds unit test for additional properties false in strict mode

5ea8112

Signed-off-by: Vincent Biret <[email protected]>

chore: adds tests for tool call behaviour and strict mode

19e7cca

Signed-off-by: Vincent Biret <[email protected]>

chore: adds unit test for new function choice behaviour options property

9e780e5

Signed-off-by: Vincent Biret <[email protected]>

chore: cleanup reference to default

733fea9

Signed-off-by: Vincent Biret <[email protected]>

fix: badly formatted doc comment

6c32a37

Signed-off-by: Vincent Biret <[email protected]>

chore: adds test for function metadata to OAI function strict more ma…

a504d03

…pping Signed-off-by: Vincent Biret <[email protected]>

chore: adds validation for strict property mapping on OpenAIFunction

5b6d51a

Signed-off-by: Vincent Biret <[email protected]>

chore: migrates to foreach

d6ca753

Signed-off-by: Vincent Biret <[email protected]>

chore: adds unit test for required properties behaviour with strict mode

4b111cb

Signed-off-by: Vincent Biret <[email protected]>

chore: adds test for metadata copy constructor

ef8de5d

Signed-off-by: Vincent Biret <[email protected]>

feat: adds strict parameter to OpenAPI based functions

873ae6a

Signed-off-by: Vincent Biret <[email protected]>

fix: pass strict when cloning function

dcaaa15

Signed-off-by: Vincent Biret <[email protected]>

smell: having to set strict in the function prompt

8342d73

Signed-off-by: Vincent Biret <[email protected]>

fix: reverts additional strict property

1152c7a

Signed-off-by: Vincent Biret <[email protected]>

fix: tests after strict property removal

5a2fae9

Signed-off-by: Vincent Biret <[email protected]>

chore: code linting

99aa4e0

Signed-off-by: Vincent Biret <[email protected]>

fix: makes schema less parameters optional in strict mode

4bbff9c

Signed-off-by: Vincent Biret <[email protected]>

feat; sanitizes forbidden strict mode keywords

34f887c

Signed-off-by: Vincent Biret <[email protected]>

fix: adds missing null type in strict mode

dff7719

Signed-off-by: Vincent Biret <[email protected]>

docs: add links to null type behaviour

f34ff32

Signed-off-by: Vincent Biret <[email protected]>

baywet requested a review from a team as a code owner December 10, 2024 12:40

markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Dec 10, 2024

github-actions bot changed the title ~~adds support for strict mode with OpenAI~~ .Net: adds support for strict mode with OpenAI Dec 10, 2024

baywet mentioned this pull request Dec 10, 2024

feat: adds strict mode support eiriktsarpalis/semantic-kernel#1

Closed

1 task

baywet had a problem deploying to integration December 10, 2024 12:41 — with GitHub Actions Failure

baywet temporarily deployed to integration December 13, 2024 12:33 — with GitHub Actions Inactive

baywet added 5 commits December 13, 2024 13:11

fix: adds support for normalizing nested properties

e5c7a9d

Signed-off-by: Vincent Biret <[email protected]>

fix: normalizes additional properties

161b199

Signed-off-by: Vincent Biret <[email protected]>

fix: additional properties can be different types

1137aea

Signed-off-by: Vincent Biret <[email protected]>

fix: handles array types for additional properties normalization

167f4f4

Signed-off-by: Vincent Biret <[email protected]>

fix: makes all properties required

6a87dd6

Signed-off-by: Vincent Biret <[email protected]>

baywet temporarily deployed to integration December 13, 2024 20:13 — with GitHub Actions Inactive

Merge branch 'main' into feat/strict-mode

7049cee

crickman temporarily deployed to integration December 16, 2024 16:37 — with GitHub Actions Inactive

baywet added 3 commits December 16, 2024 14:00

chore: enables strict mode for declarative agents

f5601b8

Signed-off-by: Vincent Biret <[email protected]>

chore: enables strict mode for CAPs and API plugins

43f1973

Signed-off-by: Vincent Biret <[email protected]>

fix: excludes forbidden default keyword

1630cdf

Signed-off-by: Vincent Biret <[email protected]>

baywet temporarily deployed to integration December 16, 2024 20:11 — with GitHub Actions Inactive

baywet added 9 commits December 17, 2024 08:49

chore: removes extraneous odata parameter filter

b8961c3

Signed-off-by: Vincent Biret <[email protected]>

chore: removes extraneous filter in api manifest extension

829812c

Signed-off-by: Vincent Biret <[email protected]>

fix: parameter filter not being passed

652b3b8

Signed-off-by: Vincent Biret <[email protected]>

fix: a bug where rest api filters would only work for dynamic payload…

1b3004c

… generation Signed-off-by: Vincent Biret <[email protected]>

feat: makes filtering properties available to the application

dcdbe46

Signed-off-by: Vincent Biret <[email protected]>

fix: adds properties trimming for CAPs demo

55ca088

Signed-off-by: Vincent Biret <[email protected]>

Merge branch 'feat/strict-mode' of https://github.com/baywet/semantic…

aa7856f

…-kernel into feat/strict-mode

Merge branch 'main' into feat/strict-mode

d59e70a

fix: drive item test for CAPs

3b296e9

Signed-off-by: Vincent Biret <[email protected]>

baywet temporarily deployed to integration December 17, 2024 18:48 — with GitHub Actions Inactive

SergeyMenshykh reviewed Jan 2, 2025

View reviewed changes

chore: use null check instead of OfType

1871283

Co-authored-by: SergeyMenshykh <[email protected]>

baywet had a problem deploying to integration January 3, 2025 12:49 — with GitHub Actions Error

fix: disables namespacing as the payload is not dynamic anymore

7fc3f96

Signed-off-by: Vincent Biret <[email protected]>

baywet had a problem deploying to integration January 3, 2025 12:54 — with GitHub Actions Error

Merge branch 'main' into feat/strict-mode

0816ece

baywet deployed to integration January 3, 2025 12:56 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.Net: adds support for strict mode with OpenAI #9924

.Net: adds support for strict mode with OpenAI #9924

baywet commented Dec 10, 2024 •

edited

Loading

SergeyMenshykh Jan 2, 2025

SergeyMenshykh Jan 2, 2025

baywet Jan 3, 2025

.Net: adds support for strict mode with OpenAI #9924

Are you sure you want to change the base?

.Net: adds support for strict mode with OpenAI #9924

Conversation

baywet commented Dec 10, 2024 • edited Loading

SergeyMenshykh Jan 2, 2025

Choose a reason for hiding this comment

SergeyMenshykh Jan 2, 2025

Choose a reason for hiding this comment

baywet Jan 3, 2025

Choose a reason for hiding this comment

baywet commented Dec 10, 2024 •

edited

Loading