Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test PR to try to add automated PR comments #884

Closed
wants to merge 19 commits into from

Conversation

DaveTryon
Copy link
Contributor

This is a placeholder test to see if we can add automatic PR comments as described at https://github.com/orgs/community/discussions/69944#discussioncomment-7281028

@DaveTryon DaveTryon requested a review from a team as a code owner January 21, 2025 23:25
@DaveTryon DaveTryon changed the title [DO NOT MERGE} Test PR to try to add automated PR comments [DO NOT MERGE] Test PR to try to add automated PR comments Jan 21, 2025
Copy link

This is just a test

Copy link

You touched the API project--how does this impact the API version?

Copy link

You touched the API project. Did you change any of the API interfaces in any way? If so, this is an API-breaking change. Please be sure you do the following:

  1. Bump the major version in the next release
  2. Update the documentation to show the new functionality

@DaveTryon DaveTryon closed this Jan 22, 2025
@DaveTryon DaveTryon deleted the DaveTryon/try-action-pr-comments branch January 22, 2025 01:21
@DaveTryon DaveTryon restored the DaveTryon/try-action-pr-comments branch January 22, 2025 17:22
@DaveTryon DaveTryon reopened this Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality and/or explain the change
  2. Bump the major version in the next release
  3. Be sure to highlight the breaking changes in the release notes

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

Copy link

This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:

  • Changing the signature of an existing interface method
  • Adding a new method to an existing interface
  • Adding a required data member to a class that an existing interface method consumes

Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:

Option 1 - Publish this as a breaking change

  1. Update the documentation to show the new functionality and/or explain the change
  2. Bump the major version in the next release

Option 2 - Refactor the changes to be non-breaking

  1. Review this commit, which adds a new interface in a backward-compatible way
  2. Refactor the change to follow this pattern so that existing interfaces are left completely intact
  3. Bump the minor version in the next release

@DaveTryon DaveTryon closed this Jan 22, 2025
@DaveTryon DaveTryon deleted the DaveTryon/try-action-pr-comments branch January 22, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant