Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add APP_INSIGHTS_ID to image build #1266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexcastilio
Copy link
Contributor

@alexcastilio alexcastilio commented Jan 24, 2025

Description

  • Add APP_INSIGHTS_ID to image build to allow monitoring through heartbeat during test execution.
  • Add test to configuration packages (for both operator and daemonset)
  • Make heartbeat interval configurable
    • New keys in deploy/standard/manifests/controller/helm/retina/values.yaml

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Manual test was also done to validate that the configuration was propagated from helm chart values.yaml file to both operator and agent. Value set was printed to log:
image
image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@alexcastilio alexcastilio force-pushed the alexcastilio/app-insights-in-image branch 3 times, most recently from fd1f6a8 to e175158 Compare January 24, 2025 14:39
@alexcastilio alexcastilio marked this pull request as ready for review January 24, 2025 14:40
@alexcastilio alexcastilio requested a review from a team as a code owner January 24, 2025 14:40
@alexcastilio alexcastilio force-pushed the alexcastilio/app-insights-in-image branch 2 times, most recently from 585155c to b82c68c Compare January 24, 2025 15:18
operator/config/config.go Outdated Show resolved Hide resolved
@alexcastilio alexcastilio requested a review from rbtr January 29, 2025 17:19
matmerr
matmerr previously approved these changes Jan 30, 2025
pkg/config/testwith/config.yaml Show resolved Hide resolved
@alexcastilio alexcastilio force-pushed the alexcastilio/app-insights-in-image branch 2 times, most recently from 381a090 to 1541467 Compare January 31, 2025 10:07
Signed-off-by: Alex Castilio dos Santos <[email protected]>
Signed-off-by: Alex Castilio dos Santos <[email protected]>
@alexcastilio alexcastilio force-pushed the alexcastilio/app-insights-in-image branch from 1541467 to 54cb9c9 Compare January 31, 2025 16:50
@ibezrukavyi ibezrukavyi self-requested a review January 31, 2025 16:52
@alexcastilio alexcastilio added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants