Upgrade samples to 0.75 #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
reviewed
Sep 6, 2024
| @@ -27,26 +27,28 @@ To upgrade this sample to the latest version of RNW: | |||
| ```cmd | |||
| npx @react-native-community/cli@latest init Calculator --template @react-native-community/template@latest | |||
There was a problem hiding this comment.
Suggested change
| npx @react-native-community/cli@latest init Calculator --template @react-native-community/template@latest | |
| npx @react-native-community/cli@latest init Calculator --version latest |
| @@ -27,26 +27,28 @@ To upgrade this sample to the latest version of RNW: | |||
| ```cmd | |||
| npx @react-native-community/cli@latest init Calculator --template @react-native-community/template@latest | |||
| ``` | |||
| 4. Add Windows support: | |||
| 4. Add `yarn.lock` file to app directory (otherwise `yarn add react-native-windows@latest` will throw an error) | |||
There was a problem hiding this comment.
It'd prefer if you just entered the Calculator folder and ran yarn install rather than creating a yarn.lock file manually.
| 4. Add Windows support: | ||
| 4. Add `yarn.lock` file to app directory (otherwise `yarn add react-native-windows@latest` will throw an error) | ||
|
|
||
| 5. Add Windows support: | ||
| ```cmd | ||
| cd Calculator | ||
| yarn add react-native-windows@latest |
There was a problem hiding this comment.
You might want to add a comment here about using the version range instead of the word latest.
TatianaKapos
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the Calculator and NativeModule samples to 0.75
Why
Part of 0.75 release: microsoft/react-native-windows#13358
Microsoft Reviewers: Open in CodeFlow