Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Experimental Fabric Calculator app #963

Merged
merged 15 commits into from
Sep 10, 2024

Conversation

TatianaKapos
Copy link
Contributor

@TatianaKapos TatianaKapos commented Aug 27, 2024

Description

Resolves #953
Since this adds CI, each project gets built. By doing this, I found out AppServiceDemo is no longer running. Turned of this test for PR for now and added an issue to the repo: #968

Why

Baseline to get upgrade coverage.

Microsoft Reviewers: Open in CodeFlow

@TatianaKapos TatianaKapos marked this pull request as ready for review September 5, 2024 18:04
@TatianaKapos TatianaKapos requested review from a team as code owners September 5, 2024 18:04
@marlenecota
Copy link
Contributor

Can you delete the ios and android folders? We don't build them or use them for anything.

@marlenecota
Copy link
Contributor

CalculatorFabric instead of CalculatorExperimental?

@TatianaKapos
Copy link
Contributor Author

@marlenecota the ios/andriod folder are present for all samples! I think it's because it show's what changes each time we upgrade the sample from one version to another.

but updated the name and changed which folder it lives in to make it more simple!

Copy link
Collaborator

@chiaramooney chiaramooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jonthysell jonthysell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine once you move disabling AppServiceDemo into another PR.

@TatianaKapos TatianaKapos enabled auto-merge (squash) September 10, 2024 17:30
@TatianaKapos TatianaKapos merged commit 0ae8afe into microsoft:main Sep 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Calculator Fabric sample
4 participants