-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Experimental Fabric Calculator app #963
Conversation
…indows-samples into tk-fabric-calc
Can you delete the ios and android folders? We don't build them or use them for anything. |
CalculatorFabric instead of CalculatorExperimental? |
@marlenecota the ios/andriod folder are present for all samples! I think it's because it show's what changes each time we upgrade the sample from one version to another. but updated the name and changed which folder it lives in to make it more simple! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine once you move disabling AppServiceDemo into another PR.
…indows-samples into tk-fabric-calc
Description
Resolves #953
Since this adds CI, each project gets built. By doing this, I found out AppServiceDemo is no longer running. Turned of this test for PR for now and added an issue to the repo: #968
Why
Baseline to get upgrade coverage.
Microsoft Reviewers: Open in CodeFlow