Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nativemodule samples to 0.76 #1001

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Upgrade nativemodule samples to 0.76 #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44f7cec
update cppwinrt
Yajur-Grover Dec 11, 2024
c7cabfa
update csharp
Yajur-Grover Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/NativeModuleSample/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

These samples showcase building Native Modules for React Native for Windows. It includes implementations in [C#](./csharp/) and [C++/WinRT](./cppwinrt/).

Both implementations target React Native Windows 0.75.
Both implementations target React Native Windows 0.76.

The official documentation can be found here:

Expand Down
13 changes: 10 additions & 3 deletions samples/NativeModuleSample/cppwinrt/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"codegen-windows": "react-native codegen-windows",
"windows": "react-native run-windows"
"windows": "npx @react-native-community/cli run-windows"
},
"peerDependencies": {
"react": "^16.13.1",
Expand All @@ -15,8 +15,8 @@
"devDependencies": {
"metro-config": "^0.66.2",
"react": "18.3.1",
"react-native": "0.75.1",
"react-native-windows": "^0.75.0"
"react-native": "0.76.2",
"react-native-windows": "^0.76.2"
},
"codegenConfig": {
"name": "NativeModuleSample",
Expand All @@ -25,5 +25,12 @@
"windows": {
"namespace": "NativeModuleSample"
}
},
"react-native-windows": {
"init-windows": {
"name": "NativeModuleSample",
"namespace": "NativeModuleSample",
"template": "old/uwp-cpp-lib"
}
}
}
8 changes: 0 additions & 8 deletions samples/NativeModuleSample/cppwinrt/windows/ExperimentalFeatures.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@
-->
<UseHermes>true</UseHermes>

<!--
Changes compilation to assume use of WinUI 3 instead of System XAML.
Requires creation of new project.

See https://microsoft.github.io/react-native-windows/docs/winui3
-->
<UseWinUI3>false</UseWinUI3>

<!--
Changes compilation to assume use of Microsoft.ReactNative NuGet packages
instead of building the framework from source.
Expand Down
2 changes: 1 addition & 1 deletion samples/NativeModuleSample/cppwinrt/windows/NativeModuleSample/NativeModuleSample.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- This project was created with react-native-windows 0.75.0 -->
<!-- This project was created with react-native-windows 0.76.2 -->
<Project ToolsVersion="Current" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(SolutionDir)\ExperimentalFeatures.props" Condition="Exists('$(SolutionDir)\ExperimentalFeatures.props')" />
<PropertyGroup Label="Globals">
Expand Down
Loading
Loading