Delete the _doc_id_rev when migrating entries #9822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abchatra
approved these changes
Jan 11, 2024
eanders-ms
approved these changes
Jan 11, 2024
riknoll
added a commit
that referenced
this pull request
Jan 12, 2024
riknoll
added a commit
that referenced
this pull request
Jan 22, 2024
…#9824) * Stop using PouchDB (#9810) * migrate pouchDB without a dependency on pouchDB * obliterate PouchDb * copy extra info to current db * fix copyToLegacyEditor * don't delete projects from pouchdb * Don't give a ridiculously high pouchdb version (#9819) * fix pouch db migration edge cases (#9820) * delete the _doc_id_rev when migrating entries (#9822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the issues I mentioned in standup with cloud sync and the pouchDB migration.
This is an internal property that pouchDB uses as its primary key. We have no reason to keep it around, and if it goes out of sync with the other project metadata it prevents a project from being synchronized on older versions of the editor.