Replace dag with flex in evals #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promptflow-evals test result 12 files 12 suites 1h 53m 26s ⏱️ Results for commit 06beae7. ♻️ This comment has been updated with latest results. |
ninghu
reviewed
Jul 9, 2024
src/promptflow-evals/promptflow/evals/evaluators/_content_safety/common/requirements.txt
Outdated
Show resolved
Hide resolved
ninghu
reviewed
Jul 9, 2024
...flow-evals/promptflow/evals/evaluators/_content_safety/_content_safety_sub_evaluator_base.py
Outdated
Show resolved
Hide resolved
ninghu
previously approved these changes
Jul 10, 2024
singankit
reviewed
Jul 10, 2024
...ptflow-evals/promptflow/evals/evaluators/_content_safety/common/evaluate_with_rai_service.py
Show resolved
Hide resolved
singankit
reviewed
Jul 10, 2024
src/promptflow-evals/promptflow/evals/evaluators/_content_safety/_hate_unfairness.py
Show resolved
Hide resolved
singankit
reviewed
Jul 10, 2024
singankit
reviewed
Jul 10, 2024
wangchao1230
previously approved these changes
Jul 12, 2024
ninghu
previously approved these changes
Jul 12, 2024
nagkumar91
previously approved these changes
Jul 12, 2024
nick863
reviewed
Jul 15, 2024
src/promptflow-evals/promptflow/evals/evaluators/_content_safety/_content_safety.py
Show resolved
Hide resolved
wangchao1230
previously approved these changes
Jul 17, 2024
ninghu
previously approved these changes
Jul 17, 2024
wangchao1230
approved these changes
Jul 18, 2024
nagkumar91
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated DAG flags from built-in evaluators in the evals pacakge, replacing them with flex flows. Functionality this amounts to directly coding the behavior specified in former flow.dag.yaml files.
This ended up editing 2 evaluators: F1 score and content safety. In the case of content safety, I used this change to refactor the code slightly into a base class and children, which mostly still exist just to have their own docstrings.