Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating doc strings for evaluate API #3283

Merged
merged 7 commits into from
May 16, 2024

Conversation

singankit
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@singankit singankit requested a review from a team as a code owner May 15, 2024 20:11
nagkumar91
nagkumar91 previously approved these changes May 15, 2024
Copy link

github-actions bot commented May 15, 2024

promptflow-evals test result

  9 files    9 suites   2h 5m 58s ⏱️
 33 tests  28 ✅  5 💤 0 ❌
297 runs  252 ✅ 45 💤 0 ❌

Results for commit 7f9b786.

♻️ This comment has been updated with latest results.

luigiw
luigiw previously approved these changes May 15, 2024
@singankit singankit dismissed stale reviews from luigiw and nagkumar91 via ab37789 May 15, 2024 21:17
nagkumar91
nagkumar91 previously approved these changes May 15, 2024
luigiw
luigiw previously approved these changes May 16, 2024
nagkumar91
nagkumar91 previously approved these changes May 16, 2024
@singankit singankit dismissed stale reviews from nagkumar91 and luigiw via 4c1c483 May 16, 2024 01:54
@singankit singankit merged commit c960a41 into main May 16, 2024
37 checks passed
@singankit singankit deleted the users/singankit/update_doc_string branch May 16, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants