Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing environment variables in chat UI #3280

Merged

Conversation

elliotzh
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

promptflow SDK CLI Azure E2E Test Result zhangxingzhi/respect-environment-variables-in-chat-ui

  4 files    4 suites   4m 8s ⏱️
243 tests 204 ✅  39 💤 0 ❌
972 runs  816 ✅ 156 💤 0 ❌

Results for commit deb3898.

Copy link

SDK CLI Global Config Test Result zhangxingzhi/respect-environment-variables-in-chat-ui

6 tests   6 ✅  1m 13s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit deb3898.

Copy link

Executor Unit Test Result zhangxingzhi/respect-environment-variables-in-chat-ui

796 tests   796 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit deb3898.

Copy link

Executor E2E Test Result zhangxingzhi/respect-environment-variables-in-chat-ui

246 tests   240 ✅  4m 59s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit deb3898.

Copy link

SDK CLI Test Result zhangxingzhi/respect-environment-variables-in-chat-ui

    4 files      4 suites   1h 5m 5s ⏱️
  783 tests   740 ✅  43 💤 0 ❌
3 132 runs  2 960 ✅ 172 💤 0 ❌

Results for commit deb3898.

@elliotzh elliotzh merged commit 7d56f97 into main May 16, 2024
41 checks passed
@elliotzh elliotzh deleted the zhangxingzhi/respect-environment-variables-in-chat-ui branch May 16, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants