Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trace][bugfix] Check both OTel environ for exporter to PFS #3274

Merged
merged 1 commit into from
May 15, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented May 15, 2024

Description

New SDK will set different environ (OTEL_EXPORTER_OTLP_TRACES_ENDPOINT), as consumer, need to check both to avoid breaking change.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang requested a review from a team as a code owner May 15, 2024 09:27
@zhengfeiwang zhengfeiwang changed the title [trace][bugfix] Add missing logic for new environ [trace][bugfix] Check both OTel environ for exporter to PFS May 15, 2024
Copy link

promptflow SDK CLI Azure E2E Test Result zhengfei/bugfix/add-otel

  4 files    4 suites   4m 12s ⏱️
243 tests 204 ✅  39 💤 0 ❌
972 runs  816 ✅ 156 💤 0 ❌

Results for commit ac8cd1e.

Copy link

SDK CLI Global Config Test Result zhengfei/bugfix/add-otel

6 tests   6 ✅  1m 15s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit ac8cd1e.

Copy link

Executor Unit Test Result zhengfei/bugfix/add-otel

796 tests   796 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit ac8cd1e.

Copy link

Executor E2E Test Result zhengfei/bugfix/add-otel

246 tests   240 ✅  5m 1s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit ac8cd1e.

Copy link

SDK CLI Test Result zhengfei/bugfix/add-otel

    4 files      4 suites   1h 4m 30s ⏱️
  783 tests   740 ✅  43 💤 0 ❌
3 132 runs  2 960 ✅ 172 💤 0 ❌

Results for commit ac8cd1e.

@zhengfeiwang zhengfeiwang merged commit 9077a0e into main May 15, 2024
41 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/bugfix/add-otel branch May 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants