New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Executor] Update script executor to support async generator in batch run #3262

Merged

thy09 merged 3 commits into main from heta/allow-async-generator-batch

May 15, 2024

Contributor

thy09 commented May 15, 2024

Description

All Promptflow Contribution checklist:

The pull request does not introduce [breaking changes].
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.
Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

thy09 requested a review from a team as a code owner

May 15, 2024 03:10

thy09 temporarily deployed to internal

May 15, 2024 03:10

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 03:10

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 03:10

— with

GitHub Actions Inactive

thy09 had a problem deploying to internal

May 15, 2024 03:10

— with

GitHub Actions Failure

thy09 temporarily deployed to internal

May 15, 2024 03:10

— with

GitHub Actions Inactive

thy09 had a problem deploying to internal

May 15, 2024 03:10

— with

GitHub Actions Failure

thy09 temporarily deployed to internal

May 15, 2024 03:10

— with

GitHub Actions Inactive

thy09 had a problem deploying to internal

May 15, 2024 03:10

— with

GitHub Actions Failure

thy09 temporarily deployed to internal

May 15, 2024 03:10

— with

GitHub Actions Inactive

thy09 had a problem deploying to internal

May 15, 2024 03:10

— with

GitHub Actions Failure

thy09 had a problem deploying to internal

May 15, 2024 03:10

— with

GitHub Actions Failure

thy09 temporarily deployed to internal

May 15, 2024 03:10

— with

GitHub Actions Inactive

thy09 had a problem deploying to internal

May 15, 2024 03:10

— with

GitHub Actions Failure

thy09 had a problem deploying to internal

May 15, 2024 03:10

— with

GitHub Actions Failure

thy09 had a problem deploying to internal

May 15, 2024 03:10

— with

GitHub Actions Failure

thy09 temporarily deployed to internal

May 15, 2024 03:10

— with

GitHub Actions Inactive

github-actions bot added the promptflow-core label

thy09 had a problem deploying to internal

May 15, 2024 03:13

— with

GitHub Actions Failure

thy09 temporarily deployed to internal

May 15, 2024 03:13

— with

GitHub Actions Inactive

github-actions bot commented May 15, 2024 •

edited

Loading

promptflow SDK CLI Azure E2E Test Result heta/allow-async-generator-batch

4 files 4 suites 4m 12s ⏱️
243 tests 204 ✅ 39 💤 0 ❌
972 runs 816 ✅ 156 💤 0 ❌

Results for commit 352cc2b.

♻️ This comment has been updated with latest results.

D-W- previously approved these changes

View reviewed changes

github-actions bot commented May 15, 2024 •

edited

Loading

SDK CLI Global Config Test Result heta/allow-async-generator-batch

6 tests 6 ✅ 1m 25s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 352cc2b.

♻️ This comment has been updated with latest results.

github-actions bot commented May 15, 2024 •

edited

Loading

Executor Unit Test Result heta/allow-async-generator-batch

796 tests 796 ✅ 3m 45s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 352cc2b.

♻️ This comment has been updated with latest results.

github-actions bot commented May 15, 2024 •

edited

Loading

Executor E2E Test Result heta/allow-async-generator-batch

246 tests 240 ✅ 5m 1s ⏱️
1 suites 6 💤
1 files 0 ❌

Results for commit 352cc2b.

♻️ This comment has been updated with latest results.

github-actions bot commented May 15, 2024 •

edited

Loading

SDK CLI Test Result heta/allow-async-generator-batch

4 files 4 suites 1h 4m 9s ⏱️
783 tests 740 ✅ 43 💤 0 ❌
3 132 runs 2 960 ✅ 172 💤 0 ❌

Results for commit 352cc2b.

♻️ This comment has been updated with latest results.

PeiwenGaoMS previously approved these changes

View reviewed changes

Heyi added 2 commits

May 15, 2024 15:49


          Update script executor to support async generator in batch run

704996f


          Fix bug and add tests

00895c2

thy09 dismissed PeiwenGaoMS’s stale review via

00895c2

May 15, 2024 08:42

thy09 temporarily deployed to internal

May 15, 2024 08:42

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 08:42

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 08:42

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 08:43

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 08:45

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 08:45

— with

GitHub Actions Inactive

github-actions bot commented May 15, 2024 •

edited

Loading

promptflow-core test result

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 352cc2b.

♻️ This comment has been updated with latest results.


          Fix flake8

352cc2b

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:11

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:13

— with

GitHub Actions Inactive

thy09 temporarily deployed to internal

May 15, 2024 09:14

— with

GitHub Actions Inactive

D-W- approved these changes

View reviewed changes

PeiwenGaoMS approved these changes

View reviewed changes

thy09 merged commit 993cb84 into main

51 checks passed

thy09 deleted the heta/allow-async-generator-batch branch

May 15, 2024 09:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

promptflow-core