Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve serverless handling and AzureAISearchSource as input #3071

Merged
merged 8 commits into from
May 7, 2024

Conversation

jingyizhu99
Copy link
Member

@jingyizhu99 jingyizhu99 commented Apr 29, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

Sample notebook updated accordingly: https://github.com/microsoft/promptflow/blob/9de72467d945112ec1e91ab323e61a6658333ead/src/promptflow-rag/build_index_sample.ipynb

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@jingyizhu99 jingyizhu99 requested a review from a team as a code owner April 29, 2024 20:04
liangjason87
liangjason87 previously approved these changes Apr 29, 2024
@jingyizhu99 jingyizhu99 merged commit 0d983e2 into main May 7, 2024
9 checks passed
@jingyizhu99 jingyizhu99 deleted the users/jingyizhu/rag/improve-build-index branch May 7, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants