fix: runtime backward compatibility #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 65be78b.
…n 1.10.0 and future releases
github-actions
bot
added
promptflow
fundamental
promptflow-devkit
promptflow-azure
labels
elliotzh
changed the title
promptflow SDK CLI Azure E2E Test Result dev/runtime-compatibility-hot-fix 4 files 4 suites 4m 6s ⏱️ Results for commit 4236e7d. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result dev/runtime-compatibility-hot-fix6 tests 6 ✅ 1m 16s ⏱️ Results for commit 4236e7d. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result dev/runtime-compatibility-hot-fix792 tests 792 ✅ 3m 44s ⏱️ Results for commit 4236e7d. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result dev/runtime-compatibility-hot-fix242 tests 237 ✅ 5m 11s ⏱️ Results for commit 4236e7d. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result dev/runtime-compatibility-hot-fix 4 files 4 suites 57m 36s ⏱️ Results for commit 4236e7d. ♻️ This comment has been updated with latest results. |
wangchao1230
previously approved these changes
Apr 28, 2024
crazygao
previously approved these changes
Apr 29, 2024
thy09
previously approved these changes
Apr 29, 2024
elliotzh
force-pushed
the
dev/runtime-compatibility-hot-fix
branch
from
833a0f9 to
605b88b
Compare
brynn-code
previously approved these changes
Apr 29, 2024
crazygao
previously approved these changes
Apr 29, 2024
thy09
previously approved these changes
Apr 29, 2024
elliotzh
force-pushed
the
dev/runtime-compatibility-hot-fix
branch
from
253bc8f to
4236e7d
Compare
brynn-code
approved these changes
Apr 29, 2024
codingrabbitt1
approved these changes
Apr 29, 2024
elliotzh
added a commit
that referenced
this pull request
Apr 30, 2024
# Description there is an issue on pip that, when installing promptflow < 1.8.0 with promptflow >= 1.8.0 installed, it will try to uninstall promptflow first, but will keep the directory _utils. after that, both the _utils directory and old _utils.py file will exist in the site-packages directory and cause import error. So: 1. we can't recover _utils.py given 1.10.0 already includes directory _utils 2. instead, we rename _utils to _utilities PR that bring this change: [link](https://github.com/microsoft/promptflow/pull/3019/files#diff-928b3b3c5544dade19729ae052cef0161ab1d6f8ea443fee17f8275ee1d6b1b4) # All Promptflow Contribution checklist: - [x] **The pull request does not introduce [breaking changes].** - [x] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [x] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [x] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. (cherry picked from commit 1a88195)
crazygao
pushed a commit
that referenced
this pull request
May 6, 2024
# Description there is an issue on pip that, when installing promptflow < 1.8.0 with promptflow >= 1.8.0 installed, it will try to uninstall promptflow first, but will keep the directory _utils. after that, both the _utils directory and old _utils.py file will exist in the site-packages directory and cause import error. So: 1. we can't recover _utils.py given 1.10.0 already includes directory _utils 2. instead, we rename _utils to _utilities PR that bring this change: [link](https://github.com/microsoft/promptflow/pull/3019/files#diff-928b3b3c5544dade19729ae052cef0161ab1d6f8ea443fee17f8275ee1d6b1b4) # All Promptflow Contribution checklist: - [x] **The pull request does not introduce [breaking changes].** - [x] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [x] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [x] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
there is an issue on pip that, when installing promptflow < 1.8.0 with promptflow >= 1.8.0 installed, it will try to
uninstall promptflow first, but will keep the directory _utils.
after that, both the _utils directory and old _utils.py file will exist in the site-packages directory and cause import error.
So:
PR that bring this change: link
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines