Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pipelines] Pipeline use federated credential #3036

Merged
merged 24 commits into from
May 9, 2024
Merged

[Pipelines] Pipeline use federated credential #3036

merged 24 commits into from
May 9, 2024

Conversation

crazygao
Copy link
Contributor

@crazygao crazygao commented Apr 26, 2024 •
edited
Loading

Description

image

It doesn't change anything about pipeline contents.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@crazygao crazygao requested a review from a team as a code owner April 26, 2024 09:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f6fc8d6.

♻️ This comment has been updated with latest results.

@crazygao crazygao changed the title [Pipelines] Pioneering fix promptflow-core pipeline use federated credential [Pipelines] Pipeline use federated credential Apr 26, 2024
@crazygao crazygao requested a review from a team as a code owner May 6, 2024 07:57
@github-actions github-actions bot removed the examples Improvements on examples label May 9, 2024
@crazygao crazygao removed the request for review from a team May 9, 2024 10:41
@crazygao crazygao merged commit dcd4e96 into main May 9, 2024
132 of 134 checks passed
@crazygao crazygao deleted the yigao/pipeline_az_login branch May 9, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 left review comments

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

@brynn-code brynn-code brynn-code approved these changes

Assignees
No one assigned
Labels
fundamental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazygao @brynn-code @zhengfeiwang @wangchao1230