Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prompty] Optimize logic for build message in prompty #2919

Merged
merged 19 commits into from
May 14, 2024

Conversation

lalala123123
Copy link
Contributor

@lalala123123 lalala123123 commented Apr 22, 2024

Description

Features:

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 22, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b739abb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 22, 2024

SDK CLI Global Config Test Result zhrua/escape_input_rool

6 tests   6 ✅  1m 14s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit b739abb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 22, 2024

Executor Unit Test Result zhrua/escape_input_rool

796 tests   796 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b739abb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 22, 2024

Executor E2E Test Result zhrua/escape_input_rool

245 tests   239 ✅  5m 14s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit b739abb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 22, 2024

SDK CLI Test Result zhrua/escape_input_rool

    4 files      4 suites   1h 3m 53s ⏱️
  724 tests   682 ✅  42 💤 0 ❌
2 896 runs  2 728 ✅ 168 💤 0 ❌

Results for commit b739abb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 22, 2024

promptflow SDK CLI Azure E2E Test Result zhrua/escape_input_rool

  4 files    4 suites   4m 12s ⏱️
242 tests 204 ✅  38 💤 0 ❌
968 runs  816 ✅ 152 💤 0 ❌

Results for commit b739abb.

♻️ This comment has been updated with latest results.

@lalala123123 lalala123123 marked this pull request as ready for review April 22, 2024 10:50
@lalala123123 lalala123123 requested a review from a team as a code owner April 22, 2024 10:50
wangchao1230
wangchao1230 previously approved these changes May 14, 2024
@lalala123123 lalala123123 changed the title [Prompty] Escape/unescape roles for input [Prompty] Optimize logic for build message in prompty May 14, 2024
@lalala123123 lalala123123 merged commit c0cb8ae into main May 14, 2024
51 checks passed
@lalala123123 lalala123123 deleted the zhrua/escape_input_rool branch May 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants