Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pf-evals package into msi #2788

Merged
merged 21 commits into from
Apr 19, 2024
Merged

Add pf-evals package into msi #2788

merged 21 commits into from
Apr 19, 2024

Conversation

YingChen1996
Copy link
Contributor

@YingChen1996 YingChen1996 commented Apr 15, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

  • Allow built-in evaluators work for C#: add pf-evals package into msi.
  • Add stop promptflow service customaction to mitigate issue when windows installer can't detect pfs detach process and close it

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@YingChen1996 YingChen1996 requested review from a team as code owners April 15, 2024 03:42
@YingChen1996
Copy link
Contributor Author

still use vbs to hidden run stop command for now. Not sure why Quieexec command can't find pf command for now
image

@elliotzh elliotzh merged commit 6d12109 into main Apr 19, 2024
10 checks passed
@elliotzh elliotzh deleted the dev/chenyin/msi_eval_package branch April 19, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants