Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trace] Move trace feature out of internal flag & improve trace experience #2767

Merged
merged 22 commits into from
Apr 12, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Apr 11, 2024

Description

This pull request targets to improve trace related experience:

  • Move start_trace in test/run submitter out of internal flag
  • Support trace.provider=none to disable trace feature, as we make it public
  • Fix bug that we will still print trace url even if we fail to invoke prompt flow service
  • Fix wrong portal urls for cloud trace
  • Fix wrong flow name retrieval

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 11, 2024

promptflow SDK CLI Azure E2E Test Result zhengfei/feature/graduate-trace

  4 files    4 suites   4m 51s ⏱️
218 tests 190 ✅  28 💤 0 ❌
872 runs  760 ✅ 112 💤 0 ❌

Results for commit 4e5c884.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

SDK CLI Global Config Test Result zhengfei/feature/graduate-trace

3 tests   3 ✅  1m 7s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 4e5c884.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

SDK CLI Test Result zhengfei/feature/graduate-trace

    4 files      4 suites   53m 11s ⏱️
  592 tests   570 ✅ 22 💤 0 ❌
2 368 runs  2 280 ✅ 88 💤 0 ❌

Results for commit 4e5c884.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Executor Unit Test Result zhengfei/feature/graduate-trace

778 tests   778 ✅  3m 42s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 4e5c884.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Executor E2E Test Result zhengfei/feature/graduate-trace

238 tests   236 ✅  5m 51s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 4e5c884.

♻️ This comment has been updated with latest results.

wangchao1230
wangchao1230 previously approved these changes Apr 12, 2024
0mza987
0mza987 previously approved these changes Apr 12, 2024
@zhengfeiwang zhengfeiwang merged commit a122d20 into main Apr 12, 2024
41 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/feature/graduate-trace branch April 12, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants