Add some package and resource checks #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brynn Yin <[email protected]>
promptflow-core test result0 tests 0 ✅ 0s ⏱️ Results for commit 82fdfbb. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result brynn/trival-bugfix-and-checks 4 files 4 suites 4m 22s ⏱️ Results for commit 82fdfbb. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result brynn/trival-bugfix-and-checks778 tests 778 ✅ 3m 44s ⏱️ Results for commit 82fdfbb. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result brynn/trival-bugfix-and-checks238 tests 236 ✅ 5m 13s ⏱️ Results for commit 82fdfbb. ♻️ This comment has been updated with latest results. |
crazygao
reviewed
Apr 11, 2024
src/promptflow-devkit/promptflow/_sdk/operations/_local_azure_connection_operations.py
Outdated
Show resolved
Hide resolved
crazygao
reviewed
Apr 11, 2024
SDK CLI Test Result brynn/trival-bugfix-and-checks 12 files 12 suites 48m 10s ⏱️ Results for commit 82fdfbb. ♻️ This comment has been updated with latest results. |
0mza987
reviewed
Apr 11, 2024
0mza987
reviewed
Apr 11, 2024
Signed-off-by: Brynn Yin <[email protected]>
Signed-off-by: Brynn Yin <[email protected]>
Signed-off-by: Brynn Yin <[email protected]>
0mza987
previously approved these changes
Apr 11, 2024
wangchao1230
previously approved these changes
Apr 11, 2024
Signed-off-by: Brynn Yin <[email protected]>
Signed-off-by: Brynn Yin <[email protected]>
github-actions
bot
added
documentation
SDK CLI Global Config Test Result brynn/trival-bugfix-and-checks3 tests 3 ✅ 47s ⏱️ Results for commit 82fdfbb. ♻️ This comment has been updated with latest results. |
Signed-off-by: Brynn Yin <[email protected]>
Signed-off-by: Brynn Yin <[email protected]>
crazygao
approved these changes
Apr 11, 2024
YingChen1996
approved these changes
Apr 11, 2024
7 tasks
brynn-code
added a commit
that referenced
this pull request
Apr 23, 2024
…/Read (#2957) # Description Please add an informative description that covers that changes made by the pull request and link all relevant issues. Side effect pr: #2751 # All Promptflow Contribution checklist: - [ ] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. Signed-off-by: Brynn Yin <[email protected]>
y1811
pushed a commit
that referenced
this pull request
Apr 24, 2024
…/Read (#2957) # Description Please add an informative description that covers that changes made by the pull request and link all relevant issues. Side effect pr: #2751 # All Promptflow Contribution checklist: - [ ] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. Signed-off-by: Brynn Yin <[email protected]>
y1811
pushed a commit
that referenced
this pull request
Apr 24, 2024
…/Read (#2957) # Description Please add an informative description that covers that changes made by the pull request and link all relevant issues. Side effect pr: #2751 # All Promptflow Contribution checklist: - [ ] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. Signed-off-by: Brynn Yin <[email protected]>
PeiwenGaoMS
pushed a commit
that referenced
this pull request
Apr 24, 2024
…/Read (#2957) # Description Please add an informative description that covers that changes made by the pull request and link all relevant issues. Side effect pr: #2751 # All Promptflow Contribution checklist: - [ ] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. Signed-off-by: Brynn Yin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines