Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Ensure same request_id for same user SDK request #1269

Closed
wants to merge 24 commits into from

Conversation

D-W-
Copy link
Contributor

@D-W- D-W- commented Nov 24, 2023

This pull request includes various changes to improve flexibility and customization in the codebase. The most important changes involve adding **kwargs parameters to several methods, passing inner_call=True to certain method calls, and removing the inner_call key from the kwargs dictionary. These changes allow for additional keyword arguments to be passed and provide more control in the execution of methods.

Main changes:

  • src/promptflow/promptflow/_sdk/operations/_run_operations.py: Added **kwargs parameter to several methods and removed inner_call key from kwargs dictionary. (Fa86a452)
  • src/promptflow/promptflow/_sdk/_submitter/utils.py: Added additional keyword arguments to resolve_connections method and init_env function. [1] [2]
  • src/promptflow/promptflow/_sdk/_submitter/test_submitter.py: Added **kwargs parameter to various methods for passing additional keyword arguments. [1] [2] [3] [4] [5] [6] [7]
  • src/promptflow/promptflow/_sdk/_submitter/run_submitter.py: Added new parameters and passed them to specific method calls for more flexibility and control. [1] [2] [3]
  • src/promptflow/promptflow/azure/operations/_run_operations.py: Added inner_call parameter and **kwargs to handle additional keyword arguments. (Fa80a065)
  • src/promptflow/promptflow/_sdk/operations/_flow_operations.py: Added **kwargs parameter to several method calls for passing additional keyword arguments. [1] [2] [3] [4] [5] [6] [7] [8]
  • src/promptflow/promptflow/_sdk/_utils.py: Updated several methods and fixed import statement. [1] [2] [3] [4]
  • src/promptflow/promptflow/_telemetry/activity.py: Removed request_id key, removed CLIENTPROXY activity type, and added logic for generating and including a request ID in telemetry logs. [1] [2] [3]
  • src/promptflow/promptflow/_sdk/operations/_connection_operations.py: Removed inner_call argument from create_or_update function and passed it separately to get function.
  • src/promptflow/promptflow/_sdk/_orm/run_info.py: Updated update function to accept additional keyword arguments.# Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Nov 24, 2023

Executor Unit Test Result wanhan/same_request_id

573 tests   572 ✔️  45s ⏱️
    1 suites      1 💤
    1 files        0

Results for commit 176671c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 24, 2023

SDK CLI Global Config Test Result wanhan/same_request_id

2 tests   2 ✔️  41s ⏱️
1 suites  0 💤
1 files    0

Results for commit 176671c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 24, 2023

Executor E2E Test Result wanhan/same_request_id

141 tests   137 ✔️  1m 46s ⏱️
    1 suites      4 💤
    1 files        0

Results for commit 176671c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 27, 2023

promptflow SDK CLI Azure E2E Test Result wanhan/same_request_id

    2 files      2 suites   1m 54s ⏱️
106 tests   88 ✔️ 18 💤 0
212 runs  176 ✔️ 36 💤 0

Results for commit 176671c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 27, 2023

SDK PFS E2E Test Result wanhan/same_request_id

  2 files    2 suites   1m 53s ⏱️
15 tests 15 ✔️ 0 💤 0
30 runs  30 ✔️ 0 💤 0

Results for commit 176671c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 27, 2023

SDK CLI Test Result wanhan/same_request_id

2 files  2 suites   18s ⏱️
1 tests 1 ✔️ 0 💤 0
2 runs  2 ✔️ 0 💤 0

Results for commit 176671c.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added examples Improvements on examples cli prompt flow CLI labels Nov 28, 2023
@D-W- D-W- closed this Nov 28, 2023
@D-W- D-W- deleted the wanhan/same_request_id branch March 27, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli prompt flow CLI examples Improvements on examples promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants