-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Ensure same request_id for same user SDK request #1269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/prompt-flow into wanhan/same_request_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to improve flexibility and customization in the codebase. The most important changes involve adding
**kwargs
parameters to several methods, passinginner_call=True
to certain method calls, and removing theinner_call
key from thekwargs
dictionary. These changes allow for additional keyword arguments to be passed and provide more control in the execution of methods.Main changes:
src/promptflow/promptflow/_sdk/operations/_run_operations.py
: Added**kwargs
parameter to several methods and removedinner_call
key fromkwargs
dictionary. (Fa86a452)src/promptflow/promptflow/_sdk/_submitter/utils.py
: Added additional keyword arguments toresolve_connections
method andinit_env
function. [1] [2]src/promptflow/promptflow/_sdk/_submitter/test_submitter.py
: Added**kwargs
parameter to various methods for passing additional keyword arguments. [1] [2] [3] [4] [5] [6] [7]src/promptflow/promptflow/_sdk/_submitter/run_submitter.py
: Added new parameters and passed them to specific method calls for more flexibility and control. [1] [2] [3]src/promptflow/promptflow/azure/operations/_run_operations.py
: Addedinner_call
parameter and**kwargs
to handle additional keyword arguments. (Fa80a065)src/promptflow/promptflow/_sdk/operations/_flow_operations.py
: Added**kwargs
parameter to several method calls for passing additional keyword arguments. [1] [2] [3] [4] [5] [6] [7] [8]src/promptflow/promptflow/_sdk/_utils.py
: Updated several methods and fixed import statement. [1] [2] [3] [4]src/promptflow/promptflow/_telemetry/activity.py
: Removedrequest_id
key, removedCLIENTPROXY
activity type, and added logic for generating and including a request ID in telemetry logs. [1] [2] [3]src/promptflow/promptflow/_sdk/operations/_connection_operations.py
: Removedinner_call
argument fromcreate_or_update
function and passed it separately toget
function.src/promptflow/promptflow/_sdk/_orm/run_info.py
: Updatedupdate
function to accept additional keyword arguments.# DescriptionPlease add an informative description that covers that changes made by the pull request and link all relevant issues.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines