Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for tool tool_with_generated_by_input #1175

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Fix test for tool tool_with_generated_by_input #1175

merged 3 commits into from
Nov 29, 2023

Conversation

liuyuhang13
Copy link
Contributor

Description

Fix test for tool tool_with_generated_by_input

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@liuyuhang13 liuyuhang13 requested a review from a team as a code owner November 17, 2023 05:42
@github-actions github-actions bot added the examples Improvements on examples label Nov 17, 2023
@liuyuhang13 liuyuhang13 merged commit 24ae410 into main Nov 29, 2023
@liuyuhang13 liuyuhang13 deleted the yuhaliu/fix_tests_for_generated_by_tool branch November 29, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorisjoy dorisjoy dorisjoy approved these changes

@chjinche chjinche chjinche approved these changes

Assignees
No one assigned
Labels
examples Improvements on examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuyuhang13 @dorisjoy @chjinche