New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK]improve error message when connection has scrubbed secrets & add CI for flow-as-func #1088

Merged

wangchao1230 merged 16 commits into main from wanhan/improve_connection_resolve

Nov 13, 2023

Contributor

D-W- commented Nov 10, 2023

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

This PR added sample CI for flow as func and improved error message when connection has scrubbed secrets.

All Promptflow Contribution checklist:

The pull request does not introduce [breaking changes].
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.
Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

D-W- added 5 commits

November 10, 2023 15:50


          hide public func

c56d668


          add check for scrubbed keys

18b426c


          update notebook

c7db386


          update template

ead6c05


          add CI

73b62a7

D-W- requested a review from a team as a code owner

November 10, 2023 08:41

D-W- temporarily deployed to internal

November 10, 2023 08:41

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 10, 2023 08:41

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 10, 2023 08:41

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 10, 2023 08:41

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 10, 2023 08:41

— with

GitHub Actions Inactive

github-actions bot added examples sdk promptflow fundamental labels

github-actions bot commented Nov 10, 2023 •

edited

Loading

Executor Unit Test Result wanhan/improve_connection_resolve

415 tests 415 ✔️ 44s ⏱️
    1 suites     0 💤
    1 files     0 ❌

Results for commit de5045a.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 10, 2023 •

edited

Loading

SDK CLI Global Config Test Result wanhan/improve_connection_resolve

2 tests 2 ✔️ 48s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit de5045a.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 10, 2023 •

edited

Loading

promptflow SDK CLI Azure E2E Test Result wanhan/improve_connection_resolve

    2 files   2 suites 44s ⏱️
  57 tests 36 ✔️ 21 💤 0 ❌
114 runs 72 ✔️ 42 💤 0 ❌

Results for commit de5045a.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 10, 2023 •

edited

Loading

SDK PFS E2E Test Result wanhan/improve_connection_resolve

8 tests 8 ✔️ 37s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit de5045a.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 10, 2023 •

edited

Loading

Executor E2E Test Result wanhan/improve_connection_resolve

139 tests 137 ✔️ 1m 44s ⏱️
    1 suites     2 💤
    1 files     0 ❌

Results for commit de5045a.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 10, 2023 •

edited

Loading

SDK CLI Test Result wanhan/improve_connection_resolve

351 tests 338 ✔️ 7m 27s ⏱️
    1 suites   13 💤
    1 files     0 ❌

Results for commit de5045a.

♻️ This comment has been updated with latest results.

D-W- commented

View reviewed changes

src/promptflow/promptflow/_core/connection_manager.py Outdated Show resolved Hide resolved

wangchao1230 reviewed

View reviewed changes

examples/tutorials/get-started/flow-as-function.ipynb Outdated Show resolved Hide resolved

wangchao1230 reviewed

View reviewed changes

src/promptflow/promptflow/_core/connection_manager.py Outdated Show resolved Hide resolved

D-W- commented

View reviewed changes

src/promptflow/promptflow/_core/connection_manager.py Outdated Show resolved Hide resolved

D-W- added 5 commits

November 10, 2023 17:32


          add test

72836da


          Merge branch 'main' into wanhan/improve_connection_resolve

30583de


          change connection to dict

9c23f3e


          update workflow

06a1841


          update

1bf6f16


          Merge branch 'main' into wanhan/improve_connection_resolve

16607ca

D-W- temporarily deployed to internal

November 13, 2023 06:56

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 06:56

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 06:56

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 06:56

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 06:56

— with

GitHub Actions Inactive

wangchao1230 reviewed

View reviewed changes

examples/tutorials/get-started/flow-as-function.ipynb Show resolved Hide resolved

wangchao1230 reviewed

View reviewed changes

.github/workflows/samples_getstarted_flowasfunction.yml Outdated Show resolved Hide resolved

D-W- added 2 commits

November 13, 2023 15:46


          fix CI

b9df417


          resolve comment

9de6830

D-W- temporarily deployed to internal

November 13, 2023 08:38

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 08:38

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 08:38

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 08:38

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 08:38

— with

GitHub Actions Inactive

wangchao1230 previously approved these changes

View reviewed changes

D-W- added 2 commits

November 13, 2023 17:45


          Merge branch 'main' into wanhan/improve_connection_resolve

8bc07bb


          skip playback

de5045a

D-W- dismissed wangchao1230’s stale review via

de5045a

November 13, 2023 10:10

D-W- temporarily deployed to internal

November 13, 2023 10:10

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 10:10

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 10:10

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 10:10

— with

GitHub Actions Inactive

D-W- temporarily deployed to internal

November 13, 2023 10:10

— with

GitHub Actions Inactive

wangchao1230 approved these changes

View reviewed changes

zhengfeiwang reviewed

View reviewed changes

examples/tutorials/get-started/flow-as-function.ipynb Show resolved Hide resolved

zhengfeiwang reviewed

View reviewed changes

examples/tutorials/get-started/flow-as-function.ipynb Show resolved Hide resolved

crazygao approved these changes

View reviewed changes

wangchao1230 merged commit 01bb286 into main

48 checks passed

wangchao1230 deleted the wanhan/improve_connection_resolve branch

November 13, 2023 11:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples fundamental promptflow sdk