Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open_Source_LLM Tool - Restore Dynamic List + Fixes #1076

Merged
merged 46 commits into from
Dec 6, 2023
Merged

Open_Source_LLM Tool - Restore Dynamic List + Fixes #1076

merged 46 commits into from
Dec 6, 2023

Conversation

gjwoods
Copy link
Contributor

@gjwoods gjwoods commented Nov 9, 2023

Description

Changes:

  1. Restore Open_Source_LLM Tool Dynamic list functionality
  2. Fixes: WS: 2806189, 2806307

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@gjwoods gjwoods requested a review from a team as a code owner November 9, 2023 19:03
@github-actions github-actions bot added the promptflow-tools promptflow tools code label Nov 9, 2023
@chenslucky
Copy link
Contributor

Please kindly revert your changes based on the latest main and try to avoid unnecessary changes to common code. The purpose is to try not to affect other tools.

@gjwoods gjwoods closed this Dec 1, 2023
@gjwoods gjwoods reopened this Dec 1, 2023
@gjwoods
Copy link
Contributor Author

gjwoods commented Dec 1, 2023

Please kindly revert your changes based on the latest main and try to avoid unnecessary changes to common code. The purpose is to try not to affect other tools.

Can you share more clarity on what you mean by this @chenslucky?
I've removed the changes from the common.py file.
For the revert of my changes - I don't follow? Are you asking me to rebase on the current main, or something else?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 5, 2023
@chenslucky
Copy link
Contributor

Can you share more clarity on what you mean by this @chenslucky? I've removed the changes from the common.py file. For the revert of my changes - I don't follow? Are you asking me to rebase on the current main, or something else?

I just saw that some codes looked like they were not changed on the latest code. Some codes seem to have been reverted back to their previous modifications. But after your confirmation, now I have no doubts and the current code seems to have no problems. Thanks.

@chenslucky chenslucky merged commit 9199acf into microsoft:main Dec 6, 2023
6 checks passed
@gjwoods gjwoods deleted the users/gewoods/dynamiclist/restore branch December 11, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation promptflow-tools promptflow tools code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants