cvm guest vsm: move vtl1_enabled from UhVpInner to a new UhCvmVpInner #842
+84
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
reviewed
Feb 12, 2025
| #[cfg(guest_arch = "x86_64")] | ||
| impl UhCvmPartitionState { | ||
| fn vp_inner(&self, vp_index: u32) -> &UhCvmVpInner { | ||
| self.vps.get(vp_index as usize).unwrap() |
There was a problem hiding this comment.
get.unwrap is just [], so just use that
smalis-msft
reviewed
Feb 12, 2025
| @@ -510,6 +510,10 @@ impl BackingPrivate for SnpBacked { | |||
| ) -> Result<(), UhRunVpError> { | |||
| this.hcvm_handle_vp_start_enable_vtl(vtl) | |||
| } | |||
|
|
|||
| fn vtl1_inspectable(this: &UhProcessor<'_, Self>) -> bool { | |||
There was a problem hiding this comment.
Do we need both vtl1_inspectable and inspect_extra? Can/should they be combined somehow? Fine for that to be a follow up, doesn't have to be here.
smalis-msft
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves some CVM-specific state off of UhVpInner into a cvm-specific struct.
Tested by booting a non-isolated VM and an SNP VM.